-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Understand why BetterEditorUndoRedo
ended up screwing AttachedOnEditor
indirectly
#73
Comments
First things first. I need to understand exactly what changes by having The test session is:
This is the respective KSP logs from two Test Sessions (with and without KSPCF). Further analysis will follow. |
This is the logs from the previous comment with only the "interesting bits" related to the problem at hands. These excerpts start when you instantiate the S4-512 tank, and finishes when you exit Editor. So it logs the TweakScale (and Analysis of these logs reveals what I had already inferred: somehow, A DIFF between these two logs revealed (left is with So, indeed, things are getting "out of order" on the process. This doesn't necessarily means any wrongdoing by Such changing behaviours can lead to bugs due the change itself, or can reveal weakness on the affected code that could be had written in a more robust way. My current working theory is that I will cross check these findings with the ones on KSPModdingLibs/KSPCommunityFixes#191 just to satisfy my inherent stubbornness on identifying exactly where and how the problem is, but GotMachine's diagnosis appears to be right. |
I choose to go grunt on the problem. I will send all the needed data on a |
Frak. It's not for any other reason than KSP is a pile of dog shit. Exceptions when fetching My code just don't know when a Invalid Key exception happened. Shit. The following code
Should be issuing a log like this:
But instead this is what I'm getting instead.
This is just maddening. You just can't trust anything on this code. |
At least, |
Related to: net-lisias-ksp/KSP-Recall#73
Implemented on commit: TweakScale/TweakScale@768fad9 === == = EDIT I mean... Commit 8fac9f1 |
Related to: net-lisias-ksp/KSP-Recall#73
Long history made short:
See KSPModdingLibs/KSPCommunityFixes#191 and KSPCF Forum for the gory details.
This absolutely weird unfortunate interaction is already mitigated, but I'm very uncomfortable it had happened at all. due:
AttachedOnEditor
is brittle.The purpose of this issue is:
BetterEditorUndoRedo
changed the runtime environment in a way that induced this misbehaviourAttachedOnEditor
had failedAttachedOnEditor
more resilient with the least collateral damage (ideally none) possible.The text was updated successfully, but these errors were encountered: