Refactor fabric template to fix jinja set bug #196
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@mtarking Did this fix the issue you were seeing? |
@mikewiebe yes it did. For this update, i just limited the number of sets and used the top-level of the model inline and if that's not found then the default is picked up. For underlay specifically, I did leave a set because of the number of items underneath it but if not found, then default to an empty dict. I'm all for some more additional testing, but things worked fine with fabric provisioning when I retested. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@mikewiebe refactoring fabric jinja template to work around inconsistency in jinja.