Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(components): Allow access to the inner reference of viewport-aware components #121

Merged
merged 2 commits into from
Sep 30, 2018
Merged

fix(components): Allow access to the inner reference of viewport-aware components #121

merged 2 commits into from
Sep 30, 2018

Conversation

bevkoski
Copy link
Collaborator

A bug reported via Medium.

The reporter worked around the issue.

This PR addresses the problem.

@bevkoski bevkoski self-assigned this Sep 30, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 364

  • 0 of 2 (0.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.1%) to 80.484%
Changes Missing Coverage Covered Lines Changed/Added Lines %
packages/components/src/viewport/aware/index.js 0 2 0.0%
Totals Coverage Status
Change from base Build 360: -0.1%
Covered Lines: 1023
Relevant Lines: 1223
💛 - Coveralls

@bevkoski bevkoski merged commit 4f88275 into master Sep 30, 2018
@bevkoski bevkoski deleted the bug/viewport-aware-ref branch September 30, 2018 08:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ognen ognen Awaiting requested review from ognen

@andon andon Awaiting requested review from andon

Assignees

@bevkoski bevkoski

Labels
bug 🐛 components
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bevkoski @coveralls