Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify local Site URL popup. #124

Merged
merged 1 commit into from
Apr 23, 2018
Merged

Clarify local Site URL popup. #124

merged 1 commit into from
Apr 23, 2018

Conversation

tech4him1
Copy link
Contributor

@tech4him1 tech4him1 commented Feb 24, 2018

This seems to cause quite a bit of confusion for some people on whether to enter their local server URL or the live Netlify site URL. This wording might need to be changed a bit, though, any thoughts?

@rafaelconde from #31:
Maybe add a documentation link somewhere? I am still not sure, but it would be nice to give some guidance to people who have no idea what it might mean, your Netlify site URL.

Related to #40.

@tech4him1 tech4him1 changed the title Update siteurl.js Clarify local Site URL popup. Feb 24, 2018
Copy link
Contributor

@bcomnes bcomnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apologies for the slow review. Things have been busy around here!

@bcomnes bcomnes merged commit 81b71f6 into netlify:master Apr 23, 2018
@tech4him1 tech4him1 deleted the patch-2 branch April 24, 2018 02:32
@tech4him1
Copy link
Contributor Author

@bcomnes No problem, can't wait to see what you guys are working on next!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants