Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: ensure dev settings for url is only visible on dev #191

Merged
merged 4 commits into from
Jun 7, 2019

Conversation

shortdiv
Copy link
Contributor

@shortdiv shortdiv commented Jun 4, 2019

Problem: Development settings for identity that would allow adding and removing an identity URL were visible on production.

This fix checks the environment and makes sure that dev settings are only visible in dev mode.

@netlify
Copy link

netlify bot commented Jun 4, 2019

Deploy Success!

Built with commit 5b46e0f

https://deploy-preview-191--identity.netlify.com

@shortdiv
Copy link
Contributor Author

shortdiv commented Jun 7, 2019

LGTM!

dogplaysjenga

@shortdiv shortdiv merged commit c104dd1 into master Jun 7, 2019
@shortdiv shortdiv deleted the development-setting branch June 7, 2019 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant