Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support latest asm in accessor-smart #70

Closed
amergey opened this issue Apr 20, 2021 · 4 comments · Fixed by #71
Closed

support latest asm in accessor-smart #70

amergey opened this issue Apr 20, 2021 · 4 comments · Fixed by #71

Comments

@amergey
Copy link
Contributor

amergey commented Apr 20, 2021

Currently accessor-smart depends on asm 8 which is a 1 year old release.
it should depends on 9.1 which is latest (and also to be able to use recent version other libs also based on asm)

if accessor-smart is supporting multiple asm version it should override osgi manifest as by default only asm 8 is supported

(for example by adding this instruction to maven-bundle-plugin in pom.xml)
<Import-Package>org.objectweb.asm;version="[8.0,10),*</Import-Package>

@UrielCh
Copy link
Contributor

UrielCh commented Apr 20, 2021

that a good opportunity to upgrade all version number :)

@UrielCh
Copy link
Contributor

UrielCh commented Apr 20, 2021

I did not use a pom.xml file for maybe 7 years,
I will be pleased to apply your changes, can you give me more detail about the changes I have to do in my maven files?

or open a PR... it's nice too. 😁

putting:

<!-- https://mvnrepository.com/artifact/org.ow2.asm/asm -->
<dependency>
    <groupId>org.ow2.asm</groupId>
    <artifactId>asm</artifactId>
    <version>9.1</version>
</dependency>

In the accessors-smart pom.xml might not be the best solution.

@amergey
Copy link
Contributor Author

amergey commented Apr 21, 2021

Do you know if accessors-smart is able to run with with asm from 8 to 9.1 ? if it is the case then updating osgi metadata only will be the best solution
I will open a PR tomorrow

@UrielCh
Copy link
Contributor

UrielCh commented Apr 21, 2021

Test unit will told us :)

amergey added a commit to amergey/json-smart-v2 that referenced this issue Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants