Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(ci/cd): added RT #150

Merged
merged 2 commits into from
Jul 19, 2023
Merged

feat(ci/cd): added RT #150

merged 2 commits into from
Jul 19, 2023

Conversation

paologallinaharbur
Copy link
Member

  • The branch of the PR is prefixed with renovate/*
  • Tests pass in renovate branches
  • security workflow is included and will pass in renovate branches
  • the changelog is validated in push_pr workflow
  • The repository has the secrets available
  • Release schedule is documented and not colliding
  • rt-update-changelog is in Makefile
  • Tags with leading v are safe
  • Common renovate config is pointed
  • Potential troublesome dependencies are checked
  • pre-release and release workflows are updated to notify failures
  • CHANGELOG.partial.md is in .gitignore
  • release-toolkit action excluded/included fields are set
  • Docker image pins go patch version
  • The dependency dashboard is sanitized --> It will be enabled when the PR is merged, and then we need to remove Worktato comment and set dependencies label.

@paologallinaharbur paologallinaharbur requested a review from a team July 19, 2023 09:09
sigilioso
sigilioso approved these changes Jul 19, 2023
View reviewed changes
Copy link
Contributor

@sigilioso sigilioso left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! (just rename the files before merging) 🙂

.github/workflows/prerelease.yml Outdated Show resolved Hide resolved
@paologallinaharbur paologallinaharbur merged commit d68bafa into master Jul 19, 2023
13 checks passed
@paologallinaharbur paologallinaharbur deleted the renovate/feat/alignRT branch July 19, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sigilioso sigilioso sigilioso approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@paologallinaharbur @sigilioso