Skip to content
This repository has been archived by the owner on Aug 20, 2024. It is now read-only.

provide schema path through the options map in validateParameters() #108

Merged
merged 5 commits into from
Oct 12, 2023
Merged

provide schema path through the options map in validateParameters() #108

merged 5 commits into from
Oct 12, 2023

Conversation

mirpedrol
Copy link
Collaborator

@mirpedrol mirpedrol commented Oct 11, 2023

All optional parameters are not provided though a map:
validateParameters(parameters_schema: 'my_params.json')

The same modification was also made for paramsSummaryMap()

⚠️ This will break pipelines who were previously providing a path using the schemaFilename argument validateParameters(schemaFilename = 'my_params.json')

@mirpedrol mirpedrol changed the title add new test and try adding a second validateParameters function provide schema path through the options map in validateParameters() Oct 11, 2023
@mirpedrol mirpedrol marked this pull request as ready for review October 11, 2023 14:37
Copy link
Collaborator

@nvnieuwk nvnieuwk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! A necessary evil IMO

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I imagine that this needs some docs updates :)

Copy link
Member

@ewels ewels left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

docs/parameters/validation.md Outdated Show resolved Hide resolved
@mirpedrol mirpedrol merged commit 3f10d18 into nextflow-io:master Oct 12, 2023
3 checks passed
@mirpedrol mirpedrol deleted the validateparameters-args branch October 12, 2023 06:16
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants