Commits on Aug 29, 2023

1. Improve data fetching error handling …

   The previous code would (depending on the sidecar file in question)
   catch fetch errors and print console errors, and then also attempt to
   load the (non-existant) data, resulting in more errors. I believe this
   was due to promise chains such as:
   
   promise.then()
     .catch()
     .then()
     .catch()
   
   and the (mis)understanding that if the first catch clause was hit
   then the entire chain would terminate.
   
   The approach implemented here also lets us differentiate between
   fetching + parsing errors, which is a subtle but nice improvement to the
   warning notifications.
   
   (Added comments are also relevant for understanding intended behaviour.)

   

   jameshadfield committed Aug 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 85cb679
   • Browse repository at this point

   Copy the full SHA

   85cb679 View commit details

   Browse the repository at this point in the history

2. Allow inline root sequence data …

   For smaller genomes it's a nicer experience to inline the root sequence
   data to avoid having to manage an extra sidecar file, with the
   downside being an (often negligible) increase in file size. This commit
   implements this by continuing our approach of conditionally fetching
   sidecars based on the data present in the main JSON.
   
   For full context, see discussions in Slack including
   <https://bedfordlab.slack.com/archives/C01LCTT7JNN/p1690930305357089>
   
   Related Augur PR <nextstrain/augur#1295>

   

   jameshadfield committed Aug 29, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for 471f457
   • Browse repository at this point

   Copy the full SHA

   471f457 View commit details

   Browse the repository at this point in the history