Hide tree options when tree is off #1698
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is a bit simpler than the ternary operator.
This conditional rendering is in place for all other panels. Make the tree panel behave the same way.
nextstrain-bot
temporarily deployed
to
auspice-victorlin-hide--vafoqb
jameshadfield
approved these changes
Sep 14, 2023
There was a problem hiding this comment.
Thanks!
Victor & I also discussed lifting the panel on-off toggles from their own section at the bottom of the sidebar up to be inline with the respective panel options ("Tree options" etc). That work can build on this PR (either here or most probably in a separate PR).
|
I started on that and realized it'll take a bit more work. I'll merge this PR now and open another PR later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
This conditional rendering is in place for all other panels. Make the tree panel behave the same way.
Related issue(s)
Testing
- [ ] (to be done by a Nextstrain team member) Create preview PRs on downstream repositories.Probably not necessary