Add types to tree component #1864
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nextstrain-bot
temporarily deployed
to
auspice-victorlin-tree--ntadob
victorlin
force-pushed
the
victorlin/tree-typing
branch
from
34d10ba
to
38b94d4
Compare
Using non-null assertions to simplify conversion. These will be addressed properly in subsequent commits.
Handle these cases better.
victorlin
force-pushed
the
victorlin/tree-typing
branch
from
38b94d4
to
4b25ff9
Compare
|
@genehack could you take a look at the types added / used here if you have a chance? 🙏 |
13 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of proposed changes
Adding types to link things together
Checklist
anysanys?