Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: Error if overlays are given for a runtime other than Docker or Singularity #354

Merged
merged 3 commits into from
Feb 1, 2024

Conversation

tsibley
Copy link
Member

@tsibley tsibley commented Jan 31, 2024

Mirrors the existing behaviour of nextstrain shell, introduced by "shell: Add support for the managed Conda runtime" (6e2d73d). It was an oversight to not do the same for nextstrain build at the same time.


Two other smaller changes too; see their commit messages.

Related issue(s)

Checklist

  • Checks pass

…ection

This, for example, allows for changelog entries to point to the
documentation pages for the exact version they're describing, so the
links don't ever go stale or broken.  Previously when I really wanted to
do that, I presupposed the version I anticipated using.
… Singularity

Mirrors the existing behaviour of `nextstrain shell`, introduced by
"shell: Add support for the managed Conda runtime" (6e2d73d).  It was an
oversight to not do the same for `nextstrain build` at the same time.
@tsibley tsibley merged commit 041847a into master Feb 1, 2024
37 checks passed
@tsibley tsibley deleted the trs/build/error-if-volumes-unsupported branch February 1, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants