Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev -> main for 3.0.2 #3219

Merged
merged 57 commits into from
Oct 11, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
57 commits
Select commit Hold shift + click to select a range
62ce0c9
Update .gitignore
maxulysse Oct 4, 2024
1c65b3b
bump version to 3.0.2dev
mashehu Oct 9, 2024
93a5bce
Merge pull request #3211 from mashehu/bump-to-3_0_2dev
mashehu Oct 9, 2024
51bbd46
assign schema_default when a param is found in the schema but not in …
mirpedrol Oct 10, 2024
972de9d
Parallelize pipeline GHA tests over docker/conda/singularity
maxulysse Oct 10, 2024
d4980ca
parse defaultIgnoreParams correctly
mashehu Oct 10, 2024
8ab88cb
[automated] Fix code linting
nf-core-bot Oct 10, 2024
16dc3b9
Merge pull request #3213 from mirpedrol/fix-params-validation
mashehu Oct 10, 2024
ba6b661
fix GHA
maxulysse Oct 10, 2024
35d7e08
fix template strings
maxulysse Oct 10, 2024
a1ff5e9
add TODO
maxulysse Oct 10, 2024
45012dd
Fix name
maxulysse Oct 10, 2024
991fa5e
Merge branch 'dev' into maxulysse-patch-6
maxulysse Oct 10, 2024
27be623
Apply suggestions from code review
maxulysse Oct 10, 2024
eb2be9a
Update nf_core/pipeline-template/.github/workflows/ci.yml
maxulysse Oct 10, 2024
1c8d74b
test -> test_name
maxulysse Oct 10, 2024
7556c0a
Update nf_core/pipeline-template/.github/workflows/ci.yml
maxulysse Oct 10, 2024
b51770c
more comments
maxulysse Oct 10, 2024
42f1de4
Update nf_core/pipeline-template/.github/workflows/ci.yml
maxulysse Oct 10, 2024
ac3d577
minimise raw and endraw blocks
mirpedrol Oct 10, 2024
0c6f4b8
Update .gitignore
maxulysse Oct 10, 2024
e3e0a83
Merge branch 'dev' into maxulysse-patch-5
maxulysse Oct 10, 2024
71d348d
Update CHANGELOG.md
maxulysse Oct 10, 2024
853060b
Update CHANGELOG.md
maxulysse Oct 10, 2024
3b8cd7f
Merge pull request #3191 from nf-core/maxulysse-patch-5
maxulysse Oct 10, 2024
dfe65d4
Merge branch 'dev' into maxulysse-patch-6
maxulysse Oct 10, 2024
3bd7105
Update nf_core/pipeline-template/.github/workflows/ci.yml
maxulysse Oct 11, 2024
88dc61c
Merge pull request #3214 from nf-core/maxulysse-patch-6
maxulysse Oct 11, 2024
dfec2cc
fix version of yaml action and change trigger event
mashehu Oct 9, 2024
06f8b4d
checkout out the PR code, change styling of message
mashehu Oct 9, 2024
a42dc29
fix condition checking if nf-core is outdated
mirpedrol Oct 10, 2024
d0c870c
use minimal-read-yaml action
mirpedrol Oct 10, 2024
3120334
use env variable to check nf-core outdated
mirpedrol Oct 10, 2024
1b429cb
update changelog
mirpedrol Oct 11, 2024
5d368d7
Merge pull request #3212 from mashehu/fix-template-version-comment-ac…
mirpedrol Oct 11, 2024
3a0ff6d
remove last mentions of old cli commands
mashehu Oct 11, 2024
9a395ad
bump version to 3.0.2
mirpedrol Oct 11, 2024
f8b2335
Merge branch 'dev' into fix-pipeline-commands-in-docstrings
ewels Oct 11, 2024
1071a30
fix changelog
mashehu Oct 11, 2024
7f9f4d7
Merge branch 'fix-pipeline-commands-in-docstrings' of github.com:mash…
mashehu Oct 11, 2024
945c921
add missing section into changelog
mashehu Oct 11, 2024
d9776bf
[automated] Update CHANGELOG.md
nf-core-bot Oct 11, 2024
07a0c62
Update CHANGELOG.md
mashehu Oct 11, 2024
310046d
Merge pull request #3215 from mashehu/fix-pipeline-commands-in-docstr…
mashehu Oct 11, 2024
807a11e
Update CHANGELOG.md
mirpedrol Oct 11, 2024
7266eb2
Merge branch 'dev' into bump-to-3.0.2
mirpedrol Oct 11, 2024
dd2d130
disable automatic sync on release, fix handling empty pipeline name f…
mashehu Oct 11, 2024
24fe05d
update changelog
mashehu Oct 11, 2024
eb7eaf9
update textual snapshots
mirpedrol Oct 11, 2024
a5a86c0
Merge pull request #3217 from mashehu/fix-sync-action
mashehu Oct 11, 2024
9bdae65
Merge pull request #3216 from mirpedrol/bump-to-3.0.2
mirpedrol Oct 11, 2024
f59c5f3
fix pre-commit lining failing on pipelines template
mirpedrol Oct 11, 2024
12084b4
use multi-line string for local swf
mirpedrol Oct 11, 2024
f2339a3
update changelog
mirpedrol Oct 11, 2024
cc713d8
update template components
mirpedrol Oct 11, 2024
658f77b
fix small typo
mirpedrol Oct 11, 2024
9cdc2da
Merge pull request #3218 from mirpedrol/fix-editorconfig
mirpedrol Oct 11, 2024
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .github/workflows/sync.yml
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
name: Sync template
on:
release:
types: [published]
# release:
# types: [published]
workflow_dispatch:
inputs:
testpipeline:
Expand Down Expand Up @@ -39,7 +39,7 @@ jobs:
run: |
if [ "${{ github.event.inputs.testpipeline }}" == "true" ]; then
echo '{"pipeline":["testpipeline"]}' > pipeline_names.json
elif [ "${{ github.event.inputs.pipeline }}" != "all" ]; then
elif [ "${{ github.event.inputs.pipeline }}" != "all" ] && [ "${{ github.event.inputs.pipeline }}" != "" ]; then
curl -O https://nf-co.re/pipeline_names.json
# check if the pipeline exists
if ! grep -q "\"${{ github.event.inputs.pipeline }}\"" pipeline_names.json; then
Expand Down
18 changes: 18 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,23 @@
# nf-core/tools: Changelog

## [v3.0.2 - Titanium Tapir Patch](https://github.com/nf-core/tools/releases/tag/3.0.2) - [2024-10-11]

### Template

- Add null/ to .gitignore ([#3191](https://github.com/nf-core/tools/pull/3191))
- Parallelize pipeline GHA tests over docker/conda/singularity ([#3214](https://github.com/nf-core/tools/pull/3214))
- Fix `template_version_comment.yml` github action ([#3212](https://github.com/nf-core/tools/pull/3212))
- Fix pre-commit linting on pipeline template ([#3218](https://github.com/nf-core/tools/pull/3218))

### Linting

- Fix bug when linting schema params and when using `defaultIgnoreParams` ([#3213](https://github.com/nf-core/tools/pull/3213))

### General

- Use updated pipeline commands in docstrings ([#3215](https://github.com/nf-core/tools/pull/3215))
- Disable automatic sync on release, fix handling empty pipeline input ([#3217](https://github.com/nf-core/tools/pull/3217))

## [v3.0.1 - Titanium Tapir Patch](https://github.com/nf-core/tools/releases/tag/3.0.1) - [2024-10-09]

### Template
Expand Down
68 changes: 47 additions & 21 deletions nf_core/pipeline-template/.github/workflows/ci.yml
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
name: nf-core CI
# This workflow runs the pipeline with the minimal test dataset to check that it completes without any syntax errors
# {% raw %}This workflow runs the pipeline with the minimal test dataset to check that it completes without any syntax errors
on:
push:
branches:
Expand All @@ -11,49 +11,75 @@ on:

env:
NXF_ANSI_LOG: false
NXF_SINGULARITY_CACHEDIR: ${{ github.workspace }}/.singularity
NXF_SINGULARITY_LIBRARYDIR: ${{ github.workspace }}/.singularity

concurrency:
group: "{% raw %}${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}{% endraw %}"
group: "${{ github.workflow }}-${{ github.event.pull_request.number || github.ref }}"
cancel-in-progress: true

jobs:
test:
name: Run pipeline with test data
name: "Run pipeline with test data (${{ matrix.NXF_VER }} | ${{ matrix.test_name }} | ${{ matrix.profile }})"
# Only run on push if this is the nf-core dev branch (merged PRs)
if: "{% raw %}${{{% endraw %} github.event_name != 'push' || (github.event_name == 'push' && github.repository == '{{ name }}') {% raw %}}}{% endraw %}"
if: "${{{% endraw %} github.event_name != 'push' || (github.event_name == 'push' && github.repository == '{{ name }}') {% raw %}}}"
runs-on: ubuntu-latest
strategy:
matrix:
NXF_VER:
- "24.04.2"
- "latest-everything"
profile:
- "conda"
- "docker"
- "singularity"
test_name:
- "test"
isMaster:
- ${{ github.base_ref == 'master' }}
# Exclude conda and singularity on dev
exclude:
- isMaster: false
profile: "conda"
- isMaster: false
profile: "singularity"
steps:
- name: Check out pipeline code
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4

- name: Install Nextflow
- name: Set up Nextflow
uses: nf-core/setup-nextflow@v2
with:
version: "{% raw %}${{ matrix.NXF_VER }}{% endraw %}"
version: "${{ matrix.NXF_VER }}"

- name: Disk space cleanup
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1
- name: Set up Apptainer
if: matrix.profile == 'singularity'
uses: eWaterCycle/setup-apptainer@main

- name: Run pipeline with test data (docker)
# TODO nf-core: You can customise CI pipeline run tests as required
# For example: adding multiple test runs with different parameters
# Remember that you can parallelise this by using strategy.matrix
- name: Set up Singularity
if: matrix.profile == 'singularity'
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test,docker --outdir ./results
mkdir -p $NXF_SINGULARITY_CACHEDIR
mkdir -p $NXF_SINGULARITY_LIBRARYDIR

- name: Set up Miniconda
if: matrix.profile == 'conda'
uses: conda-incubator/setup-miniconda@a4260408e20b96e80095f42ff7f1a15b27dd94ca # v3
with:
miniconda-version: "latest"
auto-update-conda: true
conda-solver: libmamba
channels: conda-forge,bioconda

- name: Run pipeline with test data (singularity)
# TODO nf-core: You can customise CI pipeline run tests as required
- name: Set up Conda
if: matrix.profile == 'conda'
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test,singularity --outdir ./results
if: "{% raw %}${{ github.base_ref == 'master' }}{% endraw %}"
echo $(realpath $CONDA)/condabin >> $GITHUB_PATH
echo $(realpath python) >> $GITHUB_PATH

- name: Clean up Disk space
uses: jlumbroso/free-disk-space@54081f138730dfa15788a46383842cd2f914a1be # v1.3.1

- name: Run pipeline with test data (conda)
# TODO nf-core: You can customise CI pipeline run tests as required
- name: "Run pipeline with test data ${{ matrix.NXF_VER }} | ${{ matrix.test_name }} | ${{ matrix.profile }}"
run: |
nextflow run ${GITHUB_WORKSPACE} -profile test,conda --outdir ./results
if: "{% raw %}${{ github.base_ref == 'master' }}{% endraw %}"
nextflow run ${GITHUB_WORKSPACE} -profile ${{ matrix.test_name }},${{ matrix.profile }} --outdir ./results{% endraw %}
Original file line number Diff line number Diff line change
Expand Up @@ -116,5 +116,4 @@ jobs:
exit 1
else
echo "The pipeline can be downloaded successfully!"
fi
{% endraw %}{% endif %}
fi{% endraw %}{% endif %}
Original file line number Diff line number Diff line change
Expand Up @@ -10,9 +10,11 @@ jobs:
steps:
- name: Check out pipeline code
uses: actions/checkout@0ad4b8fadaa221de15dcec353f45205ec38ea70b # v4
with:
ref: ${{ github.event.pull_request.head.sha }}

- name: Read template version from .nf-core.yml
uses: pietrobolcato/action-read-yaml@1.0.0
uses: nichmor/minimal-read-yaml@v0.0.2
id: read_yml
with:
config: ${{ github.workspace }}/.nf-core.yml
Expand All @@ -24,20 +26,21 @@ jobs:

- name: Check nf-core outdated
id: nf_core_outdated
run: pip list --outdated | grep nf-core
run: echo "OUTPUT=$(pip list --outdated | grep nf-core)" >> ${GITHUB_ENV}

- name: Post nf-core template version comment
uses: mshick/add-pr-comment@b8f338c590a895d50bcbfa6c5859251edc8952fc # v2
if: |
${{ steps.nf_core_outdated.outputs.stdout }} =~ 'nf-core'
contains(env.OUTPUT, 'nf-core')
with:
repo-token: ${{ secrets.NF_CORE_BOT_AUTH_TOKEN }}
allow-repeats: false
message: |
## :warning: Newer version of the nf-core template is available.

Your pipeline is using an old version of the nf-core template: ${{ steps.read_yml.outputs['nf_core_version'] }}.
Please update your pipeline to the latest version.

For more documentation on how to update your pipeline, please see the [nf-core documentation](https://github.com/nf-core/tools?tab=readme-ov-file#sync-a-pipeline-with-the-template) and [Synchronisation documentation](https://nf-co.re/docs/contributing/sync).
> [!WARNING]
> Newer version of the nf-core template is available.
>
> Your pipeline is using an old version of the nf-core template: ${{ steps.read_yml.outputs['nf_core_version'] }}.
> Please update your pipeline to the latest version.
>
> For more documentation on how to update your pipeline, please see the [nf-core documentation](https://github.com/nf-core/tools?tab=readme-ov-file#sync-a-pipeline-with-the-template) and [Synchronisation documentation](https://nf-co.re/docs/contributing/sync).
#{%- endraw %}
1 change: 1 addition & 0 deletions nf_core/pipeline-template/.gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -6,3 +6,4 @@ results/
testing/
testing*
*.pyc
null/
9 changes: 6 additions & 3 deletions nf_core/pipeline-template/CITATIONS.md
Original file line number Diff line number Diff line change
Expand Up @@ -15,12 +15,14 @@
{% if fastqc %}- [FastQC](https://www.bioinformatics.babraham.ac.uk/projects/fastqc/)

> Andrews, S. (2010). FastQC: A Quality Control Tool for High Throughput Sequence Data [Online].
> {% endif %}

{%- endif %}

{% if multiqc %}- [MultiQC](https://pubmed.ncbi.nlm.nih.gov/27312411/)

> Ewels P, Magnusson M, Lundin S, Käller M. MultiQC: summarize analysis results for multiple tools and samples in a single report. Bioinformatics. 2016 Oct 1;32(19):3047-8. doi: 10.1093/bioinformatics/btw354. Epub 2016 Jun 16. PubMed PMID: 27312411; PubMed Central PMCID: PMC5039924.
> {% endif %}

{%- endif %}

## Software packaging/containerisation tools

Expand All @@ -43,4 +45,5 @@
- [Singularity](https://pubmed.ncbi.nlm.nih.gov/28494014/)

> Kurtzer GM, Sochat V, Bauer MW. Singularity: Scientific containers for mobility of compute. PLoS One. 2017 May 11;12(5):e0177459. doi: 10.1371/journal.pone.0177459. eCollection 2017. PubMed PMID: 28494014; PubMed Central PMCID: PMC5426675.
> {%- endif %}

{%- endif %}
2 changes: 1 addition & 1 deletion nf_core/pipeline-template/docs/output.md
Original file line number Diff line number Diff line change
Expand Up @@ -64,7 +64,7 @@ Results generated by MultiQC collate pipeline QC from supported tools e.g. FastQ
- `pipeline_info/`
- Reports generated by Nextflow: `execution_report.html`, `execution_timeline.html`, `execution_trace.txt` and `pipeline_dag.dot`/`pipeline_dag.svg`.
{%- if email %}
- Reports generated by the pipeline: `pipeline_report.html`, `pipeline_report.txt` and `software_versions.yml`. The `pipeline_report*` files will only be present if the `--email` / `--email_on_fail` parameter's are used when running the pipeline. {% endif %}
- Reports generated by the pipeline: `pipeline_report.html`, `pipeline_report.txt` and `software_versions.yml`. The `pipeline_report*` files will only be present if the `--email` / `--email_on_fail` parameter's are used when running the pipeline.{% endif %}
- Reformatted samplesheet files used as input to the pipeline: `samplesheet.valid.csv`.
- Parameters used by the pipeline run: `params.json`.

Expand Down
3 changes: 2 additions & 1 deletion nf_core/pipeline-template/main.nf
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,8 @@ workflow {
params.outdir,
params.input
)
{% endif %}
{%- endif %}

//
// WORKFLOW: Run main workflow
//
Expand Down
6 changes: 3 additions & 3 deletions nf_core/pipeline-template/modules.json
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@
}{% endif %}{%- if multiqc %}{% if fastqc %},{% endif %}
"multiqc": {
"branch": "master",
"git_sha": "b8d36829fa84b6e404364abff787e8b07f6d058c",
"git_sha": "cf17ca47590cc578dfb47db1c2a44ef86f89976d",
"installed_by": ["modules"]
}
{%- endif %}
Expand All @@ -23,12 +23,12 @@
"nf-core": {
"utils_nextflow_pipeline": {
"branch": "master",
"git_sha": "9d05360da397692321d377b6102d2fb22507c6ef",
"git_sha": "3aa0aec1d52d492fe241919f0c6100ebf0074082",
"installed_by": ["subworkflows"]
},
"utils_nfcore_pipeline": {
"branch": "master",
"git_sha": "772684d9d66f37b650c8ba5146ac1ee3ecba2acb",
"git_sha": "1b6b9a3338d011367137808b49b923515080e3ba",
"installed_by": ["subworkflows"]
}{% if nf_schema %},
"utils_nfschema_plugin": {
Expand Down
2 changes: 1 addition & 1 deletion nf_core/pipeline-template/modules/nf-core/multiqc/main.nf

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

4 changes: 2 additions & 2 deletions nf_core/pipeline-template/nextflow.config
Original file line number Diff line number Diff line change
Expand Up @@ -288,10 +288,10 @@ validation {
"""
afterText = """${manifest.doi ? "* The pipeline\n" : ""}${manifest.doi.tokenize(",").collect { " https://doi.org/${it.trim().replace('https://doi.org/','')}"}.join("\n")}${manifest.doi ? "\n" : ""}
* The nf-core framework
https://doi.org/10.1038/s41587-020-0439-x
https://doi.org/10.1038/s41587-020-0439-x

* Software dependencies
https://github.com/${manifest.name}/blob/master/CITATIONS.md
https://github.com/${manifest.name}/blob/master/CITATIONS.md
"""{% endif %}
}{% if is_nfcore %}
summary {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,8 @@ workflow PIPELINE_INITIALISATION {
workflow.profile.tokenize(',').intersect(['conda', 'mamba']).size() >= 1
)

{% if nf_schema %}
{%- if nf_schema %}

//
// Validate parameters and generate parameter summary to stdout
//
Expand All @@ -60,7 +61,7 @@ workflow PIPELINE_INITIALISATION {
validate_params,
null
)
{% endif %}
{%- endif %}

//
// Check config provided to the pipeline
Expand All @@ -70,6 +71,7 @@ workflow PIPELINE_INITIALISATION {
)

{%- if igenomes %}

//
// Custom validation for pipeline parameters
//
Expand Down Expand Up @@ -123,7 +125,7 @@ workflow PIPELINE_COMPLETION {
email // string: email address
email_on_fail // string: email address sent on pipeline failure
plaintext_email // boolean: Send plain-text email instead of HTML
{% endif %}
{%- endif %}
outdir // path: Path to output directory where results will be published
monochrome_logs // boolean: Disable ANSI colour codes in log output
{% if adaptivecard or slackreport %}hook_url // string: hook URL for notifications{% endif %}
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

Loading
Loading