feat: disable self signed default certificate creation #1157
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
buchdag
force-pushed
the
remove-default-certificate
branch
from
9ca59c5
to
f499758
Compare
buchdag
force-pushed
the
remove-default-certificate
branch
from
f499758
to
0a34eae
Compare
buchdag
changed the title
I don't remember either. But I agree that having a self signed default certificate does not help. |
fayusohenson
pushed a commit
to fayusohenson/acme-companion
that referenced
this pull request
Oct 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR disable the self signed default certificate creation feature.
It can be re-enabled by setting
CREATE_DEFAULT_CERTIFICATEtotrueon the acme-companion container.This feature was added at a time when nginx-proxy had a bug that made it incorrectly serve (ie leak) the certificate for other domain(s) than the one that was request.
This is no longer the case, and forcing the creation of a self signed default certificate is now counter productive, with some users not understanding how they end up with a strange self signed certificate.
ping @pini-gh I think we discussed disabling this a few months ago but can't remember where.