Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

generate ROOT_EFFECTS_INIT through createAction #2218

Closed
maxisam opened this issue Nov 6, 2019 · 3 comments
Closed

generate ROOT_EFFECTS_INIT through createAction #2218

maxisam opened this issue Nov 6, 2019 · 3 comments

Comments

@maxisam
Copy link
Contributor

maxisam commented Nov 6, 2019

Currently ROOT_EFFECTS_INIT is defined from

export const ROOT_EFFECTS_INIT = '@ngrx/effects/init';

However, it doesn't work with createReducer or createEffect

Should we create this action through createAction?

@timdeschryver
Copy link
Member

Can be done, the same way as pointed out in #2206

@timdeschryver
Copy link
Member

Do you want to create a PR with these changes @maxisam ?

maxisam added a commit to maxisam/platform that referenced this issue Nov 6, 2019
@maxisam
Copy link
Contributor Author

maxisam commented Nov 6, 2019

@timdeschryver I just made a pull request but I don't know where I messed up

jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this issue Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants