Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SaveEntitiesCanceled action has the wrong type #3065

Closed
preda7or opened this issue Jul 6, 2021 · 1 comment · Fixed by #3079
Closed

SaveEntitiesCanceled action has the wrong type #3065

preda7or opened this issue Jul 6, 2021 · 1 comment · Fixed by #3079
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Data

Comments

@preda7or
Copy link

preda7or commented Jul 6, 2021

platform/modules/data/src/actions/entity-cache-action.ts

Line 169 in bf2bd1a

readonly type = EntityCacheAction.SAVE_ENTITIES_CANCEL;

Two actions should not have the same type, but SaveEntitiesCancel and SaveEntitiesCancel do.
@timdeschryver
Copy link
Member

Oh, great catch!
Feel free to open a Pull Request to modify the type to SAVE_ENTITIES_CANCELED.

@timdeschryver timdeschryver added Accepting PRs Good First Issue Good issue for first-time contributor Project: Data labels Jul 6, 2021
@AkiraTsuboi AkiraTsuboi mentioned this issue Jul 20, 2021
Merged
3 tasks
timdeschryver pushed a commit that referenced this issue Jul 21, 2021
@AkiraTsuboi
fix(data): SAVE_ENTITIES_CANCELED type in SaveEntitiesCanceled (#3079)
b24c1e0 
Closes #3065
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Accepting PRs Good First Issue Good issue for first-time contributor Project: Data
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(data): SAVE_ENTITIES_CANCELED type in SaveEntitiesCanceled
2 participants
@preda7or @timdeschryver