Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(store): support using factory selectors as extra selectors #3767

Conversation

markostanimirovic
Copy link
Member

@markostanimirovic markostanimirovic commented Feb 4, 2023

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the new behavior?

We can return factory selectors as createFeature.extraSelectors result:

export const usersFeature = createFeature({
  name: 'users',
  reducers: createReducer(initialState),
  extraSelectors: ({ selectUsers }) => ({
    selectUserById: (id: number) => createSelector(
      selectUsers,
      (users) => users.find((user) => user.id === id)
    ),
  }),
});

Does this PR introduce a breaking change?

[ ] Yes
[x] No

@netlify
Copy link

netlify bot commented Feb 4, 2023

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit f6bc48d
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63deb4a51fb8ef0009c8581f

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants