Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(data): allow ChangeSetItemFactory to update entities with number ids #1995

Merged
merged 1 commit into from
Jul 7, 2019
Merged

fix(data): allow ChangeSetItemFactory to update entities with number ids #1995

merged 1 commit into from
Jul 7, 2019

Conversation

allout58
Copy link
Contributor

@allout58 allout58 commented Jul 3, 2019

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

ChangeSetItemFactory.update only allows for entities with string type IDs

Closes #1988

What is the new behavior?

ChangeSetItemFactory.update allows for entities with string or number type IDs, to match with Update<T>

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@allout58
fix(data): allow ChangeSetItemFactory to update entities with number ids
797391d 
Allow the `update` method of ChangeSetItemFactory to accept entities with numerical IDs.
This seems to be the intent, as the `Update<T>` it accepts can use either a string or a number for the ID, while the `update` method only allows for string IDs

Closes #1988
@ngrxbot
Copy link
Collaborator

ngrxbot commented Jul 3, 2019

Preview docs changes for 797391d at https://previews.ngrx.io/pr1995-797391d/

@brandonroberts brandonroberts merged commit f11c7b2 into ngrx:master Jul 7, 2019
@brandonroberts
Copy link
Member

Thanks @allout58!

jordanpowell88 pushed a commit to jordanpowell88/platform that referenced this pull request Nov 14, 2019
@allout58 @jordanpowell88
fix(data): allow ChangeSetItemFactory to update entities with number …
acde23e 
…ids (ngrx#1995)

Allow the `update` method of ChangeSetItemFactory to accept entities with numerical IDs.
This seems to be the intent, as the `Update<T>` it accepts can use either a string or a number for the ID, while the `update` method only allows for string IDs

Closes ngrx#1988
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandonroberts brandonroberts brandonroberts approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ChangeItemSetFactory Update does not allow entities with Number IDs
3 participants
@allout58 @ngrxbot @brandonroberts