refactor: consistent naming of injection tokens #2737
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Preview docs changes for f4a6353 at https://previews.ngrx.io/pr2737-f4a6353c/ |
markostanimirovic
force-pushed
the
injection-token-naming
branch
from
aa5116a
to
f4a6353
Compare
|
@brandonroberts > ng run data:test
Nx could not find process's output. Run the command without --parallel.I restarted the workflow, hope it will fix it. |
| @@ -32,7 +32,9 @@ export interface SelectConfig { | |||
| debounce?: boolean; | |||
| } | |||
|
|
|||
| export const initialStateToken = new InjectionToken('ComponentStore InitState'); | |||
| export const INITIAL_STATE_TOKEN = new InjectionToken( | |||
There was a problem hiding this comment.
I forgot this PR.
I was thinking if this could be seen as a breaking change 🤔
There was a problem hiding this comment.
That token is part of the public API, so I would say yes
There was a problem hiding this comment.
ComponentStore's token was not supposed to be exposed 😐 It's necessary for ViewEngine backwards-compatibility.
I'm fine with leaving it for v11, at the same time I'm suspecting that our next release would be v11 🙂
timdeschryver
approved these changes
Oct 21, 2020
alex-okrushko
pushed a commit
that referenced
this pull request
Nov 3, 2020
…2737) BREAKING CHANGE: The initial state Injection Token for `@ngrx/component-store` has been renamed BEFORE: Injection Token is `initialStateToken` AFTER: Injection Token is `INITIAL_STATE_TOKEN`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Name/description of injection tokens is inconsistent.
@ngrx/component-store
@ngrx/data
@ngrx/effects
etc.
What is the new behavior?
Name/description of injection tokens is consistent.
Format:
@ngrx/module-name Title Cased DescriptionDoes this PR introduce a breaking change?
Other information