fix(store): remove afterEach hook in mock store

[cedricduffournet]

PR Checklist

Please check if your PR fulfills the following requirements:

• The commit message follows our guidelines: https://github.com/ngrx/platform/blob/master/CONTRIBUTING.md#commit
• Tests for the changes have been added (for bug fixes / features)
• Documentation has been added / updated (for bug fixes / features)

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[x] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

Closes #3243

What is the new behavior?

Does this PR introduce a breaking change?

[x] Yes
[] No

MockStore will not reset all of the mocked selectors after each test. User will need to call the MockStore.resetSelectors() method manually in a afterEach hook of a describe block

Other information

[cedricduffournet]

don't know why ci/circleci: schematics-core-check failed on CircleCI

[ngrxbot]

Preview docs changes for 9621596 at https://previews.ngrx.io/pr3245-9621596b/

[brandonroberts]

Add a comment here if why this is needed, so we'll have some context later when we can potentially remove it. Maybe just a link to the issue #

[cedricduffournet]

Ok, not sure if my english is good enough, but I tried ...

[timdeschryver]

I left one question, the rest of the PR seems good to me.

[cedricduffournet]

@timdeschryver maybe we should remove or update the following text in the doc (https://ngrx.io/guide/store/testing) :

Note: MockStore will reset all of the mocked selectors after each test (in the afterEach() hook) by calling the MockStore.resetSelectors() method.

[timdeschryver]

@cedricduffournet good catch! Feel free to do that if you want.

[cedricduffournet]

@timdeschryver I updated the doc and added a test, maybe not necessary, to show how reset selectors in afterEach hook. Let me know if you prefer that I remove it

[timdeschryver]

I think we can remove this alert, and instead, show how you can reset the store manually after each test.
About the re-added tests. I think we're already testing that resetSelector does what it's supposed to do, so these are redundant and can be removed.
Thoughts?

[cedricduffournet]

Ok, that sounds good to me. I was not sure about this test.
I'll add a code example in the doc

[timdeschryver]

Thanks again @cedricduffournet .
I left a few comments to make the example more compact.

[timdeschryver]

Thanks for your patience and thoroughness @cedricduffournet .