Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(eslint-plugin): remove @angular-devkit/schematics dependency #3710

Merged
merged 3 commits into from
Dec 20, 2022

Conversation

danielsogl
Copy link
Contributor

PR Checklist

Please check if your PR fulfills the following requirements:

PR Type

What kind of change does this PR introduce?

[x] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Build related changes
[ ] CI related changes
[ ] Documentation content changes
[ ] Other... Please describe:

What is the current behavior?

When isntallint the eslint-plugin the old v14 version of @angular-devkit/schematics will be installed

Closes #3709

What is the new behavior?

With this fix the latest v15 version of @angular-devkit/schematics will be installed

Does this PR introduce a breaking change?

[ ] Yes
[x] No

Other information

@netlify
Copy link

netlify bot commented Dec 15, 2022

Deploy Preview for ngrx-io canceled.

Built without sensitive environment variables

Name Link
🔨 Latest commit a1d88a7
🔍 Latest deploy log https://app.netlify.com/sites/ngrx-io/deploys/63a1ebafe00c4200097cc736

@danielsogl danielsogl changed the title fix(eslint-plugin): use latest @angular-devkit/schematics v15 version fix(eslint-plugin): remove @angular-devkit/schematics dependency Dec 20, 2022
Copy link
Member

@timdeschryver timdeschryver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@timdeschryver timdeschryver merged commit f0ae915 into ngrx:master Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

@angular-devkit/schematics v14 imported because of wrong @ngrx/eslint-plugin peer dependency config
3 participants