Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(Entity): Change type for EntityState to interface #454

Merged
merged 2 commits into from
Oct 10, 2017
Merged

fix(Entity): Change type for EntityState to interface #454

merged 2 commits into from
Oct 10, 2017

Conversation

brandonroberts
Copy link
Member

closes #458

@coveralls
Copy link

Coverage Status

Coverage remained the same at 91.413% when pulling 1118753 on fix-entity-state into 46d6f2f on master.

ksaifullah
ksaifullah reviewed Oct 8, 2017
View reviewed changes
modules/entity/src/models.ts
export interface EntityStateStr<T> {
ids: string[];
export interface EntityState<T> {
ids: any[];
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If the possible values of ids are either string or number, it better to be explicit about that ids: string[] | number[];.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This won't work with TypeScript

@MikeRyanDev MikeRyanDev merged commit d5640ec into master Oct 10, 2017
@MikeRyanDev MikeRyanDev deleted the fix-entity-state branch October 10, 2017 16:58
@brandonroberts brandonroberts mentioned this pull request Oct 10, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ksaifullah ksaifullah ksaifullah left review comments

Assignees

@MikeRyanDev MikeRyanDev

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@brandonroberts @coveralls @ksaifullah @MikeRyanDev