Replace ConstructorInfo Invoke with CreateInstance for improved performance #646
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reflection is used in the
PersistenceModel
to initialize the mapping classes. Currently we're using theConstructorInfo.Activate
function to create the mapping objects. Activator.CreateInstance is a bit more than twice as fast and is less code.Unfortunately, there's a fair bit of work happening in the mapping constructors so we don't see such a dramatic improvement in initialization time. Benchmarking the change against actual mapping classes and the initialization time drops by a few percentage points depending on the complexity of class.
Benchmarking the construction time of the
ProductMap
class in the example projectNot a huge performance increase but it's an easy change to make.