Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUGFIX - Fix user personnal folder creation. #4257

Merged

Conversation

corentin-soriano
Copy link
Contributor

@corentin-soriano corentin-soriano commented Jul 16, 2024

Linked to issue #4227

Always display run job button for personnal folders:
image

Fix personnal folder script:

  • PHP Fatal error: Uncaught Error: Class "ConfigManager" not found in task_maintenance_users_personal_folder.php:42
  • Only create folders for users who have personal_folder = 1
  • Remove unused code.

@corentin-soriano corentin-soriano changed the title Fix user personnal folder creation. BUGFIX - Fix user personnal folder creation. Jul 16, 2024
@DobroFenix
Copy link

Not relevant for the new version. There is now another problem with writing information about a personal folder to the database, in principle. I have not yet understood how to solve the problem - the sql query is not executed.

@corentin-soriano
Copy link
Contributor Author

Not relevant for the new version. There is now another problem with writing information about a personal folder to the database, in principle. I have not yet understood how to solve the problem - the sql query is not executed.

@DobroFenix can you describe the reproduction context?
You cloned this branch and the personal folders are still not created?
Is the scheduler configured to start automatically?
No other blocked tasks (visible in the tasks section in admin)?
image

@DobroFenix
Copy link

Since I could not run teampass locally, because even during the installation process, install/install.queries.php rained down with various errors and refused to install it. This time I launched TeamPass not locally, but inside the docker container - https://hub.docker.com/r/valterseu/teampass
In the settings, I turned on personal folders, created a user, at the top he had a notification that something was being done. But the personal folder never appeared. There are no running tasks, all tasks are completed.

image
image

@corentin-soriano
Copy link
Contributor Author

The fix is ​​not present in the docker image since it has not yet been validated and merged by Nils.

@DobroFenix
Copy link

Got that. Thank you.
At least so...
It's a pity TeamPass failed to run locally.
I hope he shows up and puts together a working version.

@nilsteampassnet nilsteampassnet merged commit 7137d22 into nilsteampassnet:master Aug 25, 2024
2 of 4 checks passed
@nilsteampassnet
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants