Add access grant check on backend side. #4346
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently places in php where access grants on items are not properly checked.
A malicious user can edit the request before sending it to the server or edit the DOM with the debug console to bypass restrictions.
Now:
hidden
class on.form-item-delete
.Using the code from
check_current_access_rights
query to create functiongetCurrentAccessRights()
.Returns
true
instead ofnull
which was confusing.