Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old style exceptions --> new style for Python 3 #1411

Closed
wants to merge 1 commit into from
Closed

Old style exceptions --> new style for Python 3 #1411

wants to merge 1 commit into from

Conversation

cclauss
Copy link
Contributor

@cclauss cclauss commented Jul 23, 2018

Python 3 treats old style exceptions as syntax errors.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (nodejs/node#21942)

Python 3 treats old style exceptions as syntax errors.

Discovered via https://travis-ci.com/nodejs/node/builds/79706150 (nodejs/node#21942)
@cclauss
Copy link
Contributor Author

cclauss commented Jul 23, 2018

@maclover7 Would it be possible for you to add two tests on Python 2 and Python 3 to Jenkins:

    - pip install flake8
    # stop the build if there are Python syntax errors or undefined names
    - flake8 . --count --select=E901,E999,F821,F822,F823 --show-source --statistics
    # exit-zero treats all errors as warnings.  The GitHub editor is 127 chars wide
    - flake8 . --count --exit-zero --max-complexity=10 --max-line-length=127 --statistics

I have never been able to figure out Jenkins and it would great to learn from you how it can be done.

@refack
Copy link
Contributor

refack commented Jul 24, 2018

See #1399

@maclover7
Copy link
Contributor

@cclauss Thank you for the PR! Unfortunately, as @refack already commented, he already filed a PR to upgrade our Python scripts from 2 to 3. Going to close in favor of that PR, since it was opened first, and we can continue the discussion over there :)

@maclover7 maclover7 closed this Jul 24, 2018
@cclauss cclauss deleted the patch-1 branch July 24, 2018 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants