remove the need for xcodebuild #1057

gdams · 2016-11-23T10:54:58Z

xcodebuild now requires full xcode and not just developer tools
I have removed all commands that use xcode build and there seems to be no issues. This also means that we don't get the error message anymore.
What is the reason we actually need to use xcodebuild?

I know that this is something that should probably be raised with gyp upstream, but I wanted to make sure that this seems reasonable first.

I have removed all commands that use xcode build and there seems to be no issues. This means that we don't get the error message anymore.

rvagg · 2016-11-23T11:22:42Z

You may need to ask upstream about this, honestly I have no idea whether this is a good idea or not.

refack · 2017-05-02T15:51:23Z

FYI, trying to push this upstream https://chromium-review.googlesource.com/c/492046/ voice your opinion

gibfahn · 2017-10-20T13:41:18Z

According to @bnoordhuis in #1267 (comment) we don't pull things from GYP any more, therefore this should be good to land?

gibfahn · 2017-10-20T13:41:49Z

This should also go into the copy of GYP vendored into node, to fix the ./configure errors.

refack · 2017-10-20T18:03:25Z

I kicked off a dry run on the upstream CL, so we can at least benefit from their CI coverage.

gibfahn · 2017-10-20T18:15:42Z

I kicked off a dry run on the upstream CL, so we can at least benefit from their CI coverage.

👍 , and if you think there's a chance you'll succeed in the upstreaming then I'm happy to do that, it just seems unlikely to ever make it back into node-gyp or node at this point.

refack · 2017-10-20T18:47:15Z

I kicked off a dry run on the upstream CL, so we can at least benefit from their CI coverage.

👍 , and if you think there's a chance you'll succeed in the upstreaming then I'm happy to do that, it just seems unlikely to ever make it back into node-gyp or node at this point.

As for upstreaming, Dirk approves pretty much every reasonable change (that is not Mac or ninja).
I try to keep core's GYP up to date, and there's #1183 to bump it here.
But it seems like chromium broke the trybots for GYP, so maybe we need to set up our own.

gibfahn · 2017-10-20T18:51:28Z

As for upstreaming, Dirk approves pretty much every reasonable change (that is not Mac or ninja).

But this is Mac right?

haribharadwaj · 2018-01-03T16:37:36Z

With just the command-line tools, how might one accept the Xcode license? Previously xcodebuild was used for that.

gibfahn · 2018-01-03T17:23:21Z

With just the command-line tools, how might one accept the Xcode license? Previously xcodebuild was used for that.

When you install the command-line tools, it pops up a UI where you accept the license.

As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run. Refs: nodejs#1057 Refs: https://chromium-review.googlesource.com/c/492046/

As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run. Refs: nodejs#1057 Refs: https://chromium-review.googlesource.com/c/492046/ Refs: nodejs#569

As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run. PR-URL: nodejs#1370 Refs: nodejs#1057 Refs: https://chromium-review.googlesource.com/c/492046/ Refs: nodejs#569

As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be printing the error every time GYP is run. PR-URL: nodejs#1370 Fixes: nodejs#569 Refs: nodejs#1057 Refs: https://chromium-review.googlesource.com/c/492046/

gibfahn · 2018-06-29T11:53:23Z

#1370 was merged.

lebed2045 · 2018-07-17T04:02:35Z

I'm not sure why it closed, because of node-gyp still needs damn xcode which I can't install because I never have enough space. I assume I'm not alone here with the same problem.
Example, try to run npm install web3 which uses node-gyp.
xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

gibfahn · 2018-07-17T14:38:03Z

node-gyp still needs damn xcode which I can't install because I never have enough space. I assume I'm not alone here with the same problem.

No it doesn't, that is just a warning which will not affect your build.

I'm not sure why it closed,

Did you look at #1370 ? The title is gyp: don't print xcodebuild not found errors. Once you update to a version of npm that has a version of node-gyp that has that commit then the warning will go away.

jrock2004 · 2018-12-21T21:32:34Z

@gibfahn I am guessing the issue is that most people are using plugins that use node-gyp and do not have that control. For example, I just upgraded to Node 11.5 and trying to install node-sass and getting this error.

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance

Traceback (most recent call last):
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/gyp_main.py", line 16, in <module>
    sys.exit(gyp.script_main())
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 545, in script_main
    return main(sys.argv[1:])
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 538, in main
    return gyp_main(args)
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/__init__.py", line 523, in gyp_main
    generator.GenerateOutput(flat_list, targets, data, params)
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py", line 2170, in GenerateOutput
    part_of_all=qualified_target in needed_targets)
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py", line 795, in Write
    self.Pchify))
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/generator/make.py", line 1190, in WriteSources
    cflags = self.xcode_settings.GetCflags(configname)
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 551, in GetCflags
    archs = self.GetActiveArchs(self.configname)
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 420, in GetActiveArchs
    xcode_archs_default = GetXcodeArchsDefault()
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 118, in GetXcodeArchsDefault
    xcode_version, _ = XcodeVersion()
  File "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/gyp/pylib/gyp/xcode_emulation.py", line 1265, in XcodeVersion
    version = re.match(r'(\d\.\d\.?\d*)', version).groups()[0]
AttributeError: 'NoneType' object has no attribute 'groups'
gyp ERR! configure error
gyp ERR! stack Error: `gyp` failed with exit code: 1
gyp ERR! stack     at ChildProcess.onCpExit (/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/lib/configure.js:336:16)
gyp ERR! stack     at ChildProcess.emit (events.js:189:13)
gyp ERR! stack     at Process.ChildProcess._handle.onexit (internal/child_process.js:254:12)
gyp ERR! System Darwin 18.2.0
gyp ERR! command "/usr/local/Cellar/node/11.5.0/bin/node" "/Users/jcostanzo/Development/embermap-cms/node_modules/node-gyp/bin/node-gyp.js" "rebuild" "--verbose" "--libsass_ext=" "--libsass_cflags=" "--libsass_ldflags=" "--libsass_library="
gyp ERR! cwd /Users/jcostanzo/Development/embermap-cms/node_modules/node-sass
gyp ERR! node -v v11.5.0
gyp ERR! node-gyp -v v3.6.2
gyp ERR! not ok```

l02162010 · 2018-12-26T03:48:16Z

@jrock2004 I have same problem

mkochco · 2019-02-23T17:05:38Z

@jrock2004 - ran into the same problem on Node.js release lines 8 (8.15.1) and 10 (10.0.0). Release line 6 (6.9.5) worked fine. Resolution on 8 and 10 required that Xcode be fully installed and that sudo xcode-select --reset had been run.

DorelBesliu · 2024-04-25T15:20:53Z

Thank you @mkochco

remove the need for xcodebuild

7d1dd77

I have removed all commands that use xcode build and there seems to be no issues. This means that we don't get the error message anymore.

gibfahn mentioned this pull request Feb 6, 2017

[ci/osx] xcode-select: error: tool 'xcodebuild' requires Xcode nodejs/build#615

Closed

This was referenced Apr 14, 2017

test: fix parallel/test-setproctitle.js on alpine nodejs/node#12413

Closed

build: fix ninja build failure nodejs/node#12484

Closed

xcrun error when building master nodejs/node#12531

Closed

davis mentioned this pull request Oct 28, 2017

xcode-select: error: tool 'xcodebuild' requires Xcode, but active developer directory '/Library/Developer/CommandLineTools' is a command line tools instance #569

Closed

gibfahn mentioned this pull request Jan 21, 2018

gyp: don't print xcodebuild not found errors #1370

Merged

2 tasks

gibfahn closed this Jun 29, 2018

larryob mentioned this pull request Oct 25, 2018

Unable to install/update v4.4 on OSX 0mkara/etheratom#191

Open

vichug mentioned this pull request Jan 6, 2019

command 'make setup' fails on macOS high sierra Provenance-Emu/Provenance#1055

Closed

16 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

remove the need for xcodebuild #1057

remove the need for xcodebuild #1057

gdams commented Nov 23, 2016 •

edited

Loading

rvagg commented Nov 23, 2016

refack commented May 2, 2017

gibfahn commented Oct 20, 2017

gibfahn commented Oct 20, 2017

refack commented Oct 20, 2017

gibfahn commented Oct 20, 2017

refack commented Oct 20, 2017

gibfahn commented Oct 20, 2017

haribharadwaj commented Jan 3, 2018

gibfahn commented Jan 3, 2018

gibfahn commented Jun 29, 2018

lebed2045 commented Jul 17, 2018

gibfahn commented Jul 17, 2018

jrock2004 commented Dec 21, 2018

l02162010 commented Dec 26, 2018

mkochco commented Feb 23, 2019

DorelBesliu commented Apr 25, 2024

remove the need for xcodebuild #1057

remove the need for xcodebuild #1057

Conversation

gdams commented Nov 23, 2016 • edited Loading

rvagg commented Nov 23, 2016

refack commented May 2, 2017

gibfahn commented Oct 20, 2017

gibfahn commented Oct 20, 2017

refack commented Oct 20, 2017

gibfahn commented Oct 20, 2017

refack commented Oct 20, 2017

gibfahn commented Oct 20, 2017

haribharadwaj commented Jan 3, 2018

gibfahn commented Jan 3, 2018

gibfahn commented Jun 29, 2018

lebed2045 commented Jul 17, 2018

gibfahn commented Jul 17, 2018

jrock2004 commented Dec 21, 2018

l02162010 commented Dec 26, 2018

mkochco commented Feb 23, 2019

DorelBesliu commented Apr 25, 2024

gdams commented Nov 23, 2016 •

edited

Loading