Fix infinite install loop. #1384
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gibfahn
reviewed
Feb 27, 2018
| function eaccesFallback () { | ||
| function eaccesFallback (err) { | ||
| var noretry = '--node_gyp_internal_noretry' | ||
| if (-1 !== argv.indexOf(noretry)) return cb(err) |
There was a problem hiding this comment.
Non-blocking Bikeshed:
Using a yoda expression and a one-line if statement seems odd here. The yoda is presumably to make it easier to read, but squashing onto one line makes it harder to read.
if (-1 !== argv.indexOf(noretry)) return cb(err)if (argv.indexOf(noretry) !== -1) {
return cb(err)
}nbd, more curious than anything else.
There was a problem hiding this comment.
I like my guard statements on one line, mainly for greppability.
|
I added a test that skirts around doing actual I/O, PTAL. |
gibfahn
approved these changes
Feb 27, 2018
richardlau
reviewed
Feb 27, 2018
| } | ||
|
|
||
| gyp.commands.install([], function (err) { | ||
| t.ok(true) |
There was a problem hiding this comment.
Could this test be removed and the test count reduced to 2?
There was a problem hiding this comment.
Well, you want to know that the final callback is called, right? Or do I misunderstand you?
|
https://ci.nodejs.org/job/nodegyp-test-pull-request/44/ - unbreak another test. |
richardlau
approved these changes
Feb 27, 2018
Retry the download+install dance only once after encountering an EACCES. That only happens when both the devdir (usually: `$HOME/.node-gyp`) and the current working directory aren't writable. Users won't often hit that except through `sudo npm install` because npm drops privileges before executing node-gyp. Fixes: #1383 PR-URL: #1384 Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Retry the download+install dance only once after encountering an EACCES.
That only happens when both the devdir (usually:
$HOME/.node-gyp) andthe current working directory aren't writable. Users won't often hit
that except through
sudo npm installbecause npm drops privilegesbefore executing node-gyp.
Fixes #1383.