path: fix posix.relative() on Windows

Fixes: #13683
nodejs · Mar 14, 2021 · 2875ab1 · 2875ab1
1 parent 85edaf4
commit 2875ab1
Show file tree

Hide file tree

Showing 3 changed files with 5 additions and 16 deletions.
diff --git a/lib/path.js b/lib/path.js
@@ -23,6 +23,7 @@
 
 const {
   FunctionPrototypeBind,
+  RegExp,
   StringPrototypeCharCodeAt,
   StringPrototypeLastIndexOf,
   StringPrototypeSlice,
@@ -1099,8 +1100,10 @@ const posix = {
       return '';
 
     // Trim leading forward slashes.
-    from = posix.resolve(from);
-    to = posix.resolve(to);
+    from = module.exports.resolve(from)
+      .replace(new RegExp(`\\${module.exports.sep}`, 'g'), posix.sep);
+    to = module.exports.resolve(to)
+      .replace(new RegExp(`\\${module.exports.sep}`, 'g'), posix.sep);
 
     if (from === to)
       return '';

diff --git a/test/known_issues/known_issues.status b/test/known_issues/known_issues.status
@@ -15,32 +15,18 @@ test-vm-timeout-escape-queuemicrotask: SKIP
 [$system==win32]
 
 [$system==linux]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$system==macos]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$system==solaris]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$system==freebsd]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$system==aix]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$arch==arm]
 # The Raspberry Pis are too slow to run this test.
 # See https://github.com/nodejs/build/issues/2227#issuecomment-608334574
 test-crypto-authenticated-stream: SKIP
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
 
 [$system==ibmi]
-# Windows-specific test
-test-path-posix-relative-on-windows: SKIP
diff --git a/...es/test-path-posix-relative-on-windows.js → ...el/test-path-posix-relative-on-windows.js b/...es/test-path-posix-relative-on-windows.js → ...el/test-path-posix-relative-on-windows.js