crypto: fixup bug in keygen error handling

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #36779 Refs: #36729 Reviewed-By: Tobias Nießen <tniessen@tnie.de>
nodejs · Jan 12, 2021 · 42aca13 · 42aca13
1 parent 4c819d6
commit 42aca13
Showing 1 changed file with 4 additions and 2 deletions.
diff --git a/lib/internal/crypto/keygen.js b/lib/internal/crypto/keygen.js
@@ -94,13 +94,15 @@ function generateKeyPairSync(type, options) {
 }
 
 function handleError(ret) {
-  if (ret === undefined)
+  if (ret == null)
     return; // async
 
-  const [err, [publicKey, privateKey]] = ret;
+  const [err, keys] = ret;
   if (err !== undefined)
     throw err;
 
+  const [publicKey, privateKey] = keys;
+
   // If no encoding was chosen, return key objects instead.
   return {
     publicKey: wrapKey(publicKey, PublicKeyObject),