stream: fix non readable Duplex readableAborted

nodejs · Nov 13, 2021 · 4c06554 · 4c06554
1 parent f217025
commit 4c06554
Show file tree

Hide file tree

Showing 2 changed files with 14 additions and 2 deletions.
diff --git a/lib/internal/streams/readable.js b/lib/internal/streams/readable.js
@@ -1187,8 +1187,11 @@ ObjectDefineProperties(Readable.prototype, {
   readableAborted: {
     enumerable: false,
     get: function() {
-      return !!(this._readableState.destroyed || this._readableState.errored) &&
-        !this._readableState.endEmitted;
+      return !!(
+        this._readableState.readable &&
+        (this._readableState.destroyed || this._readableState.errored) &&
+        !this._readableState.endEmitted
+      );
     }
   },
 

diff --git a/test/parallel/test-stream-readable-aborted.js b/test/parallel/test-stream-readable-aborted.js
@@ -55,3 +55,12 @@ const { Readable } = require('stream');
   }));
   readable.resume();
 }
+
+{
+  const duplex = new Duplex({
+    readable: false,
+    write () {}
+  });
+  duplex.destroy();
+  assert.strictEqual(readable.readableAborted, false);
+}