Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deps: update openssl to 1.0.1j #1

Closed
wants to merge 1 commit into from

Conversation

indutny
Copy link
Member

@indutny indutny commented Nov 27, 2014

@bnoordhuis
Copy link
Member

Rubber-stamp LGTM. It would be nice if the commit log explained why it fixes nodejs/node-v0.x-archive#8555.

@indutny
Copy link
Member Author

indutny commented Nov 27, 2014

Erm, I guess I'd just remove the reference, as it is fixing only the comment in issue, not the issue itself.

indutny added a commit that referenced this pull request Nov 27, 2014
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
PR-URL: #1
@indutny
Copy link
Member Author

indutny commented Nov 27, 2014

Landed in 574407a, thank you!

@indutny indutny closed this Nov 27, 2014
@indutny indutny deleted the feature/update-openssl-1.0.1-j branch November 27, 2014 16:57
@rektide rektide mentioned this pull request May 28, 2015
3 tasks
@Avinash-Raj Avinash-Raj mentioned this pull request Feb 10, 2016
@ghost ghost mentioned this pull request Jun 20, 2024
sungpaks added a commit to sungpaks/node that referenced this pull request Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message
"Can't read package.json" on non-existent file. However, the subtests
failed on Ubuntu20.04. we found that attempting to run a non-existent
script like `node --run foo` using the latest version of node results in
an error message like `Can't find “scripts” field in package.json`
(on Ubuntu20.04, regardless of whether package.json is present in the
subpath or not). So we modified the subtest so that if we match either
of the two messages, the test passes.
sungpaks added a commit to sungpaks/node that referenced this pull request Jul 29, 2024
Subtest nodejs#1, nodejs#2 of test-node-run.js originally matched the error message
"Can't read package.json" on non-existent file. However, the subtests
failed on Ubuntu20.04. we found that attempting to run a non-existent
script like `node --run foo` using the latest version of node results in
an error message like `Can't find “scripts” field in package.json`
(on Ubuntu20.04, regardless of whether package.json is present in the
subpath or not). So we modified the subtest so that if we match either
of the two messages, the test passes.
giancorderoortiz added a commit to giancorderoortiz/node_backports that referenced this pull request Sep 6, 2024
Original commit message:

    Merged: [parser] Using FunctionParsingScope for parsing class static blocks

    Class static blocks contain statements, don't inherit the
    ExpressionScope stack.

    (cherry picked from commit 3e037e195e508dea045f5626862412e8f64fc919)

    Bug: 341663589
    Change-Id: Ice9a710293b028e5d9fd30d5d85c4842f970b152
    Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/5558360
    Reviewed-by: Adam Klein <adamk@chromium.org>
    Reviewed-by: Shu-yu Guo <syg@chromium.org>
    Commit-Queue: Adam Klein <adamk@chromium.org>
    Cr-Commit-Position: refs/branch-heads/12.4@{nodejs#38}
    Cr-Branched-From: 309640da62fae0485c7e4f64829627c92d53b35d-refs/heads/12.4.254@{nodejs#1}
    Cr-Branched-From: 5dc24701432278556a9829d27c532f974643e6df-refs/heads/main@{#92862}

Refs: v8/v8@6e5e105
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants