installer: install ICU header files

[bnoordhuis]

Also add a smoke test to ensure that linking to the bundled ICU works.

(Perhaps this should be two commits.)

CI: https://ci.nodejs.org/job/node-test-pull-request/7205/

[srl295]

Makes sense. With system the system provided headers.

[bnoordhuis]

This should probably also install i18n/unicode and (possibly?) io/unicode.

@srl295 What does ICU consider public API and what internal?

[bnoordhuis]

Windows link errors...

binding.obj : error LNK2001: unresolved external symbol ulocdata_getCLDRVersion_58 [c:\workspace\node-test-binary-windows\RUN_SUBSET\0\VS_VERSION\vs2015\label\win2012r2\test\addons\icu-binding\build\binding.vcxproj]
binding.obj : error LNK2001: unresolved external symbol u_versionToString_58 [c:\workspace\node-test-binary-windows\RUN_SUBSET\0\VS_VERSION\vs2015\label\win2012r2\test\addons\icu-binding\build\binding.vcxproj]

@srl295 Is that an ICU bug? ICU seems to be quite diligent in tagging everything dllexport but it doesn't do it for functions mangled with U_ICU_ENTRY_POINT_RENAME().

[bnoordhuis]

Switched to TimeZone::getTZDataVersion() (which is marked dllexport) and added i18n/unicode to the list of directories to install. CI: https://ci.nodejs.org/job/node-test-pull-request/7223/

@srl295 Can you PTAL?

[bnoordhuis]

God, Windows... I'm going to guess i18n only uses dllexport when the right U_*_IMPLEMENTATION define is set at node build time, otherwise this shouldn't happen:

binding.obj : error LNK2001: unresolved external symbol "__declspec(dllimport) public: static char const * __cdecl icu_58::TimeZone::getTZDataVersion(enum UErrorCode &)" 

Will dig further.

[srl295]

@bnoordhuis yes, U_*_IMPLEMENTATION needs to be set. let me find the link…

OK. for a shlib you need to set U_*_IMPLEMENTATION as in https://github.com/nodejs/node/blob/master/tools/icu/icu-generic.gyp#L496

Within node, since it's static, I would set U_STATIC_IMPLEMENTATION https://github.com/nodejs/node/blob/master/tools/icu/icu-generic.gyp#L46

OK, I'm confused…  Node is built statically, including ICU. How is the linking supposed to work?

I think in icu-generic.gyp you need to change in both places U_STATIC_IMPLEMENTATION (export nothing) to U_COMBINED_IMPLEMENTATION (export everything as one library)

[BridgeAR]

Ping @bnoordhuis

[BridgeAR]

@bnoordhuis does this still need much work? It is stalled since quite a while and I would otherwise close this.

[srl295]

so, what I said in #12217 (comment)

I think in icu-generic.gyp you need to change in both places U_STATIC_IMPLEMENTATION (export nothing) to U_COMBINED_IMPLEMENTATION (export everything as one library)

if that is set, it might work on Windows.

[BridgeAR]

Closing this due to the long inactivity and no response. @bnoordhuis please reopen if you would like to pursue this further.