Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix calls of deprecated assert methods #23673

Merged
merged 2 commits into from
Nov 10, 2018
Merged

test: fix calls of deprecated assert methods #23673

merged 2 commits into from
Nov 10, 2018

Conversation

prog1dev
Copy link
Contributor

@prog1dev prog1dev commented Oct 15, 2018 •
edited
Loading

Just went through assert docs and fixed calls of deprecated methods in tests:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

@nodejs-github-bot nodejs-github-bot added test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem. labels Oct 15, 2018
@prog1dev prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 35ab12b to b235d9f Compare October 15, 2018 18:04
@prog1dev prog1dev changed the title test: remove assert.equal from test-tty-get-color-depth.js test test: remove calls of deprecated assert methods Oct 15, 2018
@prog1dev prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from b235d9f to 1e137d1 Compare October 15, 2018 18:15
@prog1dev prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 1e137d1 to 76f0ba9 Compare October 28, 2018 14:24
@prog1dev
Copy link
Contributor Author

prog1dev commented Nov 1, 2018

Could you guys review this please?
@vsemozhetbyt @lpinca @richardlau

@vsemozhetbyt
Copy link
Contributor

vsemozhetbyt commented Nov 1, 2018 •
edited
Loading

I am only confident enough to humbly ping @nodejs/testing, @nodejs/assert and maybe @BridgeAR.

BridgeAR
BridgeAR approved these changes Nov 1, 2018
View reviewed changes
Copy link
Member

@BridgeAR BridgeAR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with my comment addressed.

test/async-hooks/init-hooks.js Outdated Show resolved Hide resolved
@BridgeAR
Copy link
Member

BridgeAR commented Nov 1, 2018

@vsemozhetbyt thanks for the ping.

@prog1dev prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 76f0ba9 to 9a71b82 Compare November 1, 2018 17:23
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18281/

@prog1dev prog1dev force-pushed the test/remove_depricated_assert_equal_method branch from 9a71b82 to d2421b2 Compare November 4, 2018 22:02
@prog1dev prog1dev changed the title test: remove calls of deprecated assert methods test: fix calls of deprecated assert methods Nov 4, 2018
@Trott
Copy link
Member

Trott commented Nov 6, 2018

CI: https://ci.nodejs.org/job/node-test-pull-request/18355/

@prog1dev
Copy link
Contributor Author

ci build is green

@prog1dev @refack
test: use assert.strictEqual instead of assert.equal
936ac68 
PR-URL: nodejs#23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@prog1dev @refack
test: fix uses of deprecated assert.fail with multiple args
53d424a 
PR-URL: nodejs#23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@refack refack force-pushed the test/remove_depricated_assert_equal_method branch from d2421b2 to 53d424a Compare November 10, 2018 16:47
@refack
Copy link
Contributor

refack commented Nov 10, 2018

Landed in 04ccc98...53d424a 🎉

@refack refack merged commit 53d424a into nodejs:master Nov 10, 2018
@prog1dev prog1dev deleted the test/remove_depricated_assert_equal_method branch November 10, 2018 19:41
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@prog1dev @BridgeAR
test: use assert.strictEqual instead of assert.equal
2b0410a 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
BridgeAR pushed a commit that referenced this pull request Nov 14, 2018
@prog1dev @BridgeAR
test: fix uses of deprecated assert.fail with multiple args
9af7ad5 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@BridgeAR BridgeAR mentioned this pull request Nov 14, 2018
Merged
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@prog1dev @kiyomizumia
test: use assert.strictEqual instead of assert.equal
3e14526 
PR-URL: nodejs#23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
kiyomizumia pushed a commit to kiyomizumia/node that referenced this pull request Nov 15, 2018
@prog1dev @kiyomizumia
test: fix uses of deprecated assert.fail with multiple args
59ccf58 
PR-URL: nodejs#23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
This was referenced Nov 15, 2018
Closed
Closed
Closed
Closed
Closed
Closed
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@prog1dev @codebytere
test: use assert.strictEqual instead of assert.equal
8209ecd 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
codebytere pushed a commit that referenced this pull request Dec 14, 2018
@prog1dev @codebytere
test: fix uses of deprecated assert.fail with multiple args
a3289bd 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@prog1dev @MylesBorins
test: use assert.strictEqual instead of assert.equal
c417c7a 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
MylesBorins pushed a commit that referenced this pull request Dec 26, 2018
@prog1dev @MylesBorins
test: fix uses of deprecated assert.fail with multiple args
4054c24 
PR-URL: #23673
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Refael Ackermann <refack@gmail.com>
@codebytere codebytere mentioned this pull request Jan 4, 2019
Merged
This was referenced Jan 29, 2019
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott left review comments

@refack refack refack approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

Assignees
No one assigned
Labels
test Issues and PRs related to the tests. tty Issues and PRs related to the tty subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@prog1dev @vsemozhetbyt @BridgeAR @Trott @refack @nodejs-github-bot