test: swap expected and actual in assert.strictEqual #24146
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cjihrig
approved these changes
Nov 6, 2018
gireeshpunathil
approved these changes
Nov 6, 2018
addaleax
added
the
code-and-learn
addaleax
approved these changes
Nov 6, 2018
addaleax
approved these changes
Nov 6, 2018
BridgeAR
approved these changes
Nov 6, 2018
trivikr
reviewed
Nov 7, 2018
| assert.strictEqual(twoByteString.indexOf('\u03a3', -4, 'ucs2'), 6); | ||
| assert.strictEqual(twoByteString.indexOf('\u03a3', -6, 'ucs2'), 4); | ||
| assert.strictEqual(twoByteString.indexOf( | ||
| Buffer.from('\u03a3', 'ucs2'), -6, 'ucs2'), 4); | ||
| assert.strictEqual(-1, twoByteString.indexOf('\u03a3', -2, 'ucs2')); |
There was a problem hiding this comment.
The order needs to be swapped for -1 too - on this line and other lines
There was a problem hiding this comment.
I thought that too, but the code an learn task was to change only a specific set of lines.
|
Hi @bilbieflorin, the author of this commit is not registered on Github (steps defined here) Either:
|
|
Hi @trivikr! The git was configured with my work email. I added it to my github account and should be displaying the author correctly now. Thanks for telling me about this! |
trivikr
approved these changes
Nov 7, 2018
|
pls thumbs up for fast tracking |
gireeshpunathil
added
the
author ready
|
Landed in 791ad09. Thanks for the contribution! 🎉 (If you're interested in other possible contributions to Node.js but don't have a good idea of where to start looking, some ideas are posted at https://www.nodetodo.org/next-steps/.) |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Nov 8, 2018
PR-URL: nodejs#24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Nov 14, 2018
PR-URL: #24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
kiyomizumia
pushed a commit
to kiyomizumia/node
that referenced
this pull request
Nov 15, 2018
PR-URL: nodejs#24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This was referenced Nov 15, 2018
codebytere
pushed a commit
that referenced
this pull request
Dec 13, 2018
PR-URL: #24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 26, 2018
PR-URL: #24146 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This was referenced Jan 29, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes