Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

repl: handle buffered string logic on finish #24389

Closed
wants to merge 1 commit into from

Conversation

antsmartian
Copy link
Contributor

@antsmartian antsmartian commented Nov 16, 2018

Fixes : #24385

Looks like clearBufferedCommand will be called on almost all flows. Hence history was broken. Sorry about that, but I take this as learning and see why history test cases didn't catch up this in first place. I will spend some time this weekend to add few more test cases on to repl history which caused this regression.

Can some one ping repl team to make it land faster?

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem. labels Nov 16, 2018
@Trott
Copy link
Member

Trott commented Nov 16, 2018

@nodejs/repl

@antsmartian
Copy link
Contributor Author

cc @vsemozhetbyt

@vsemozhetbyt
Copy link
Contributor

Who do we need to cc to not forget including this fix in the security release that will be created soon?

@antsmartian
Copy link
Contributor Author

@vsemozhetbyt Oh if this gets included in that release, it will be great :) Thanks for the follow up.

@Fishrock123
Copy link
Contributor

lib/readline.js Outdated Show resolved Hide resolved
@vsemozhetbyt vsemozhetbyt added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 19, 2018
@vsemozhetbyt
Copy link
Contributor

CI: https://ci.nodejs.org/job/node-test-pull-request/18764/

@antsmartian
Copy link
Contributor Author

@vsemozhetbyt You are super fast :)

@Fishrock123
Copy link
Contributor

Bleh, some unrelated ARM failure.

Thanks, landed in eb42c1e.

(Hopefully I did that right... been an awfully long time since I landed anything...)

Fishrock123 pushed a commit that referenced this pull request Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Made an issue about the ARM failure (a crash): #24496

Fishrock123 pushed a commit that referenced this pull request Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Fishrock123 commented Nov 19, 2018

Landed on 11.x in c11d345

targos pushed a commit that referenced this pull request Nov 19, 2018
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@antsmartian
Copy link
Contributor Author

Thanks @Fishrock123

@antsmartian antsmartian deleted the repl-history branch November 20, 2018 02:21
@targos
Copy link
Member

targos commented Nov 20, 2018

@Fishrock123 v11.x should only be updated when a release is merged. Can you force push to remove the commit?

@targos
Copy link
Member

targos commented Nov 20, 2018

I fixed it, but had to temporarily unprotect the release branches to do so.

@targos
Copy link
Member

targos commented Nov 20, 2018

@Fishrock123 No worries, btw :) I opened an issue in the Release repo to discuss a way to prevent this mistake in the future: nodejs/Release#392

@antsmartian
Copy link
Contributor Author

@targos Thanks. Not sure if this commit bit (#22153) is backported to 10.x stages. If so, we need to backport this fix to 10.x as well.

rvagg pushed a commit that referenced this pull request Nov 28, 2018
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: #24389
Fixes: #24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@BridgeAR BridgeAR mentioned this pull request Dec 5, 2018
4 tasks
refack pushed a commit to refack/node that referenced this pull request Jan 14, 2019
Looks like `clearBufferedCommand` will be called on almost all flows.
Hence history was broken.

PR-URL: nodejs#24389
Fixes: nodejs#24385
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module. repl Issues and PRs related to the REPL subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

9 participants