src: elevate v8 namespaces for node_process.cc #24578
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
c++
cjihrig
approved these changes
Nov 24, 2018
|
@gireeshpunathil : Pls review |
refack
approved these changes
Nov 26, 2018
gireeshpunathil
approved these changes
Nov 26, 2018
|
@Jayasankar-m Would you be able to rebase this PR and resolve the conflict in |
Jayasankar-m
force-pushed
the
v8nodeprocess
branch
from
52a2e7d
to
0be503e
Compare
@danbev : Done!! Please review. |
Jayasankar-m
force-pushed
the
v8nodeprocess
branch
2 times, most recently
from
292bc83
to
ca0076a
Compare
elevate namespace for repeated entities. resolved conflicts.
Jayasankar-m
force-pushed
the
v8nodeprocess
branch
from
ca0076a
to
d1e0c1c
Compare
danbev
approved these changes
Nov 29, 2018
|
Re-run failing node-test-commit-freebsd |
jasnell
approved these changes
Nov 30, 2018
|
Resume Build CI: https://ci.nodejs.org/job/node-test-commit/23835/ ✔️ |
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 1, 2018
Elevate namespace for repeated entities. Resolved conflicts. PR-URL: nodejs#24578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in bbb9d37 |
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
Elevate namespace for repeated entities. Resolved conflicts. PR-URL: #24578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
Elevate namespace for repeated entities. Resolved conflicts. PR-URL: nodejs#24578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Jun 25, 2019
Elevate namespace for repeated entities. Resolved conflicts. PR-URL: #24578 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
elevate namespace for repeated entities.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes