lib: convert to arrow function #24623
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
child_process
hiroppy
added
the
code-and-learn
joyeecheung
reviewed
Nov 24, 2018
lib/internal/child_process.js
Outdated
| @@ -68,25 +68,25 @@ const handleConversion = { | |||
| 'net.Native': { | |||
| simultaneousAccepts: true, | |||
|
|
|||
| send: function(message, handle, options) { | |||
| send: (message, handle, options) => { | |||
There was a problem hiding this comment.
I'd think changing this pattern to something like
send(message, handle, options) {
would be even better?
There was a problem hiding this comment.
Thanks @joyeecheung
I will review my changes according to your suggestion.
cjihrig
approved these changes
Nov 25, 2018
Leko
approved these changes
Nov 26, 2018
shisama
approved these changes
Nov 28, 2018
|
landed as b8bd4b4 thank you for @horihiro the contribution! Wish you great success with continued contribution to this project, if you are further interested please have a look at https://www.nodetodo.org/next-steps |
pull bot
pushed a commit
to SimenB/node
that referenced
this pull request
Nov 28, 2018
PR-URL: nodejs#24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
targos
pushed a commit
that referenced
this pull request
Nov 28, 2018
PR-URL: #24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Merged
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24623 Reviewed-By: Shingo Inoue <leko.noor@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Masashi Hirano <shisama07@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts to Arrow Function
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes