doc: fix added version of randomFill+randomFillSync #24812
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
crypto
|
It seems we already support multiple versions here. See code changes and test examples in 00ffa33, in particular |
|
@vsemozhetbyt updated with both versions in the |
addaleax
approved these changes
Dec 3, 2018
vsemozhetbyt
approved these changes
Dec 3, 2018
vsemozhetbyt
added
the
author ready
|
Node.js Collaborators, please, add 👍 here if you approve fast-tracking. |
cjihrig
approved these changes
Dec 3, 2018
Fishrock123
approved these changes
Dec 3, 2018
lpinca
approved these changes
Dec 3, 2018
thefourtheye
approved these changes
Dec 3, 2018
|
Landed in fa19ce9 |
watson
added a commit
that referenced
this pull request
Dec 3, 2018
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Dec 5, 2018
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Dec 7, 2018
refack
pushed a commit
to refack/node
that referenced
this pull request
Jan 14, 2019
PR-URL: nodejs#24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Feb 12, 2019
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Feb 20, 2019
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
rvagg
pushed a commit
that referenced
this pull request
Feb 28, 2019
PR-URL: #24812 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
crypto.randomFillandcrypto.randomFillSyncwas backported to Node.js 6.13.0 but the documentation wasn't updated. So the documentation still says that this was added in v7.10.0.This PR updates that to say v6.13.0, but I'm honestly not really sure if that's the best solution. Because it of course means that it wasn't there between version 7.0.0 and 7.9.0.Possible solutions:Don't care because 7.x isn't EoLAdd a row to thechanges:section saying that it wasn't there between 7.0.0 and 7.9.0Update the yaml parser to support that a function be added in more than one different major@nodejs/documentation What do you think?Update: Changed the PR according to #24812 (comment)
Checklist