Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: move require('https') to after crypto check #25388

Closed
wants to merge 2 commits into from
Closed

test: move require('https') to after crypto check #25388

wants to merge 2 commits into from

Commits on Jan 8, 2019

  1. test: move require('https') to after crypto check 

    Currently, test-https-client-override-global-agent.js fails with the
following error when configured --without-ssl:

Error [ERR_NO_CRYPTO]:
Node.js is not compiled with OpenSSL crypto support
  at Object.assertCrypto (internal/util.js:101:11)
  ...
  at Object.<anonymous>
  (/node/test/parallel/test-https-client-override-global-agent.js:5:15)

This commit moves the require statement to after the crypto check.
    @danbev
    danbev committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    09cda82 View commit details
    Browse the repository at this point in the history

  2. squash! move hasCrypto straight after common req

    @danbev
    danbev committed Jan 8, 2019
    Configuration menu
    Copy the full SHA
    3ad31a9 View commit details
    Browse the repository at this point in the history