Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: make mkssldef.py Python 3 compatible #25584

Conversation

thefourtheye
Copy link
Contributor

This patch replaces the usage of map in such a way that it will be
compatible with Python 3.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

cc @nodejs/python @cclauss

This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.
@nodejs-github-bot nodejs-github-bot added openssl Issues and PRs related to the OpenSSL dependency. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory. labels Jan 19, 2019
@refack refack added the python PRs and issues that require attention from people who are familiar with Python. label Jan 19, 2019
Copy link
Member

@bnoordhuis bnoordhuis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left a comment but LGTM either way.

exported = []

for filename in filenames:
for line in open(filename).readlines():
name, _, _, meta, _ = re.split('\s+', line)
if any(map(lambda p: p.match(name), excludes)): continue
if any([p.match(name) for p in excludes]): continue
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need the square brackets here, any() accepts a generator.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changed it to a generator now.

@addaleax
Copy link
Member

@addaleax addaleax added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 27, 2019
@danbev
Copy link
Contributor

danbev commented Jan 28, 2019

Re-run of failing node-test-commit-windows-fanned ✔️

@danbev
Copy link
Contributor

danbev commented Jan 28, 2019

Landed in 4814987.

@danbev danbev closed this Jan 28, 2019
danbev pushed a commit that referenced this pull request Jan 28, 2019
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@thefourtheye thefourtheye deleted the make-mkssldef.py-python3-compatible branch January 28, 2019 13:00
addaleax pushed a commit that referenced this pull request Jan 28, 2019
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@targos targos mentioned this pull request Jan 29, 2019
BethGriggs pushed a commit that referenced this pull request Apr 29, 2019
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
BethGriggs pushed a commit that referenced this pull request May 10, 2019
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
MylesBorins pushed a commit that referenced this pull request May 16, 2019
This patch replaces the usage of `map` in such a way that it will be
compatible with Python 3.

PR-URL: #25584
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. openssl Issues and PRs related to the OpenSSL dependency. python PRs and issues that require attention from people who are familiar with Python. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants