Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix test-https-ci-reneg-attack #25676

Closed
wants to merge 2 commits into from

Commits on Jan 24, 2019

  1. test: fix renegotiation tests in pummel

    With a recent OpenSSL update to core, a change in the behavior of
    `s_client` result in pummel test failures because they spam with
    renegotiation requests before the renegotiation is complete. Modify
    tests to reduce initial spamming.
    
    This fixes the TLS renegotiation test. While it fixes the bug in the
    HTTPS test too, that is still failing with the OpenSSL update for other
    (too-be-determined) reasons.
    
    Refs: nodejs#25381 (comment)
    Trott committed Jan 24, 2019
    Configuration menu
    Copy the full SHA
    6e26064 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    6b40106 View commit details
    Browse the repository at this point in the history