Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

win, build: add arbitrary MSBuild flag option and binlog option #25994

Closed
wants to merge 1 commit into from

Conversation

jkunkee
Copy link
Contributor

@jkunkee jkunkee commented Feb 7, 2019

This commit adds a 'verbose' flag to vcbuild.bat that turns on outputs
useful for build debugging, including MSBuild BinLogging and
DEBUG_HELPER logging.

It also adds a 'setlocal' call so internal environment variables no
longer leak out to the calling shell.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

[Edit: Note new commit message (cf0681c)]

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform. labels Feb 7, 2019
@jkunkee jkunkee changed the title win, build: add 'verbose' mode and improve environment management win, build: add 'verbose' mode and scope environment changes Feb 7, 2019
vcbuild.bat Outdated Show resolved Hide resolved
@refack
Copy link
Contributor

refack commented Feb 7, 2019

Hello @jkunkee
and welcome. Thank you for your contribution 🥇
If you are not familiar with our review and landing process, it's covered in CONTRIBUTING.md

I like the idea behind the proposed change, but I think we can do it with a simpler, more generic way 🤷‍♂️.

P.S. If you have any questions you can also feel free to contact me directly.

@refack
Copy link
Contributor

refack commented Feb 7, 2019

/CC @nodejs/build-files @nodejs/platform-windows

@jkunkee
Copy link
Contributor Author

jkunkee commented Feb 8, 2019

Thanks for the welcome and the review! I've reread the contributor and PR guides and will email you soon.

@jkunkee jkunkee force-pushed the win-build-script-tweaks branch 2 times, most recently from 4bed141 to 490f726 Compare February 9, 2019 18:31
vcbuild.bat Outdated Show resolved Hide resolved
@jkunkee jkunkee force-pushed the win-build-script-tweaks branch 2 times, most recently from 4edce07 to cf0681c Compare February 9, 2019 23:59
@jkunkee jkunkee changed the title win, build: add 'verbose' mode and scope environment changes win, build: add arbitrary MSBuild flag option and binlog option Feb 10, 2019
@jkunkee
Copy link
Contributor Author

jkunkee commented Feb 10, 2019

Note new commit message (cf0681c)

@joaocgreis
Copy link
Member

joaocgreis commented Feb 13, 2019

CI: https://ci.nodejs.org/view/All/job/node-test-pull-request/20750/ ❌ (arm-fanned)
Resumed: https://ci.nodejs.org/view/All/job/node-test-pull-request/20765/ ✔️

@refack does your request for changes still hold?

This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.
@joaocgreis
Copy link
Member

joaocgreis commented Mar 4, 2019

@refack I believe your feedback has been addressed, I'll assume there's no problem with landing this.

CI: https://ci.nodejs.org/job/node-test-pull-request/21182/ ✔️

joaocgreis pushed a commit that referenced this pull request Mar 4, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
@joaocgreis
Copy link
Member

Landed in d57c526
Thanks @jkunkee!

@jkunkee
Copy link
Contributor Author

jkunkee commented Mar 4, 2019

Thanks, @joaocgreis!

BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 6, 2019
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
@jkunkee jkunkee deleted the win-build-script-tweaks branch March 8, 2019 02:40
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
BridgeAR pushed a commit to BridgeAR/node that referenced this pull request Mar 12, 2019
PR-URL: nodejs#26431
Refs: nodejs#25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR pushed a commit that referenced this pull request Mar 14, 2019
PR-URL: #26431
Refs: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BethGriggs pushed a commit that referenced this pull request Apr 16, 2019
This change adds a 'msbuild_arg' option to vcbuild.bat that can be used
to pass arbitrary flags to MSBuild.

It also adds a 'binlog' flag as a shortcut 'msbuild_arg' option to
enable binary logging to `%config%\node.binlog`. This is especially
convenient when debugging changes to the build system.

In the process of developing this change, the idea of adding 'setlocal'
to the beginning of the script was rejected since other scripts in this
repo rely on the exported environment variables. This change adds a
note describing this.

PR-URL: #25994
Reviewed-By: João Reis <reis@janeasystems.com>
@BethGriggs BethGriggs mentioned this pull request May 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. windows Issues and PRs related to the Windows platform.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants