doc: edit deprecation section of Collaborator Guide #26419
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Edit the last few paragraphs of the Collaborator Guide section on deprecations.
BethGriggs
approved these changes
Mar 4, 2019
targos
approved these changes
Mar 4, 2019
Trott
added
the
author ready
vsemozhetbyt
approved these changes
Mar 4, 2019
vsemozhetbyt
added
meta
richardlau
approved these changes
Mar 4, 2019
| @@ -334,7 +334,7 @@ documentation must state the deprecation status. | |||
| * Emits a warning at runtime on first use of the deprecated API. | |||
| * If used with the [`--throw-deprecation`][] flag, will throw a runtime error. | |||
|
|
|||
| * End-of-life | |||
| * End-of-Life | |||
There was a problem hiding this comment.
I thought we'd added a lint rule for this, but we forbade End-Of-Life. A quick search shows End-of-life also appears in BUILDING.md, so nodejs/remark-preset-lint-node#13.
BridgeAR
approved these changes
Mar 5, 2019
jasnell
approved these changes
Mar 5, 2019
|
Landed in 05606c6 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Mar 6, 2019
Edit the last few paragraphs of the Collaborator Guide section on deprecations. PR-URL: nodejs#26419 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
Edit the last few paragraphs of the Collaborator Guide section on deprecations. PR-URL: nodejs#26419 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
Edit the last few paragraphs of the Collaborator Guide section on deprecations. PR-URL: #26419 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Vse Mozhet Byt <vsemozhetbyt@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Edit the last few paragraphs of the Collaborator Guide section on
deprecations.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes