build: indicate that configure has done something #26436
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If run without `--verbose` configure exits silently with no indication that it has done anything. Print a message on completion to indicate that the script has worked. Refs: nodejs#23111
nodejs-github-bot
added
the
build
lpinca
approved these changes
Mar 4, 2019
richardlau
added
the
author ready
BridgeAR
approved these changes
Mar 4, 2019
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 6, 2019
If run without `--verbose` configure exits silently with no indication that it has done anything. Print a message on completion to indicate that the script has worked. Refs: nodejs#23111 PR-URL: nodejs#26436 Refs: nodejs#23111 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
|
Landed in ceb73e7 🎉 |
BridgeAR
pushed a commit
to BridgeAR/node
that referenced
this pull request
Mar 12, 2019
If run without `--verbose` configure exits silently with no indication that it has done anything. Print a message on completion to indicate that the script has worked. Refs: nodejs#23111 PR-URL: nodejs#26436 Refs: nodejs#23111 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
BridgeAR
pushed a commit
that referenced
this pull request
Mar 14, 2019
If run without `--verbose` configure exits silently with no indication that it has done anything. Print a message on completion to indicate that the script has worked. Refs: #23111 PR-URL: #26436 Refs: #23111 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Print a message on completion to indicate that the
configurescript has worked.Currently running
configurewithout--verboseprints:but that info message will disappear with the next ICU update so what will happen is that
configurewill exit without indicating that anything has happened:This PR changes the output to:
Refs: #23111
cc @nodejs/build-files
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes