Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: improve UV_THREADPOOL_SIZE description #29033

Closed
wants to merge 1 commit into from
Closed

doc: improve UV_THREADPOOL_SIZE description #29033

wants to merge 1 commit into from

Conversation

tniessen
Copy link
Member

@tniessen tniessen commented Aug 7, 2019

The UV_THREADPOOL_SIZE documentation claims that only three crypto APIs use the thread pool, which is not true anymore. This commit lists all relevant APIs and rephrases it such that future API additions are included in the documentation.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Aug 7, 2019
@antsmartian antsmartian added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Aug 7, 2019
@Trott
Copy link
Member

Trott commented Aug 8, 2019

Lite CI: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/3825/ ✔️

@tniessen
Copy link
Member Author

tniessen commented Aug 9, 2019

Landed in 885c644, thanks for reviewing!

@tniessen tniessen closed this Aug 9, 2019
tniessen added a commit that referenced this pull request Aug 9, 2019
@tniessen
doc: improve UV_THREADPOOL_SIZE description
885c644 
PR-URL: #29033
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Aug 19, 2019
@tniessen @targos
doc: improve UV_THREADPOOL_SIZE description
375d1ee 
PR-URL: #29033
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@targos targos mentioned this pull request Aug 19, 2019
Merged
This was referenced Aug 20, 2019
Closed
Closed
Closed
Closed
Closed
Closed
@tniessen tniessen removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bnoordhuis bnoordhuis bnoordhuis approved these changes

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@antsmartian antsmartian antsmartian approved these changes

@lpinca lpinca lpinca approved these changes

@cjihrig cjihrig cjihrig approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

@trivikr trivikr trivikr approved these changes

Assignees
No one assigned
Labels
cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
10 participants
@tniessen @Trott @bnoordhuis @jasnell @antsmartian @lpinca @cjihrig @BethGriggs @trivikr @nodejs-github-bot