Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools,doc: fix global table of content active element #34976

Closed
wants to merge 0 commits into from
Closed

tools,doc: fix global table of content active element #34976

wants to merge 0 commits into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Aug 29, 2020

Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: nav-module and nav-modules).

Fixes: #34975

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Aug 29, 2020
@DerekNonGeneric
Copy link
Contributor

That doesn't seem to have done it. Providing a screenshot might convince me otherwise, but would you mind double-checking?

DerekNonGeneric
DerekNonGeneric approved these changes Aug 29, 2020
View reviewed changes
Copy link
Contributor

@DerekNonGeneric DerekNonGeneric left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nevermind, this does indeed resolve the bug. I had forgotten to rebuild the docs.

@DerekNonGeneric DerekNonGeneric added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Aug 31, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 3, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33030/

DerekNonGeneric pushed a commit that referenced this pull request Sep 3, 2020
@aduh95
tools,doc: fix global table of content active element
79ea22a 
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: `nav-module` and `nav-modules`).

Fixes: #34975

PR-URL: #34976
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@DerekNonGeneric
Copy link
Contributor

Landed in 79ea22a

@aduh95 aduh95 closed this Sep 3, 2020
@aduh95 aduh95 deleted the patch-4 branch September 3, 2020 10:49
richardlau pushed a commit that referenced this pull request Sep 3, 2020
@aduh95 @richardlau
tools,doc: fix global table of content active element
fb2111e 
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: `nav-module` and `nav-modules`).

Fixes: #34975

PR-URL: #34976
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@richardlau richardlau mentioned this pull request Sep 3, 2020
Merged
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@aduh95 @addaleax
tools,doc: fix global table of content active element
7fa6c99 
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: `nav-module` and `nav-modules`).

Fixes: #34975

PR-URL: #34976
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
@aduh95 @addaleax
tools,doc: fix global table of content active element
0ec3e61 
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: `nav-module` and `nav-modules`).

Fixes: #34975

PR-URL: #34976
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@codebytere codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@aduh95 @joesepi
tools,doc: fix global table of content active element
08d8579 
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: `nav-module` and `nav-modules`).

Fixes: nodejs#34975

PR-URL: nodejs#34976
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
@Dmarch28 Dmarch28 mentioned this pull request May 10, 2022
Open
@snyk-bot snyk-bot mentioned this pull request May 10, 2022
Open
@137717unity 137717unity mentioned this pull request May 10, 2022
Open
@baby636 baby636 mentioned this pull request May 10, 2022
Open
@kissofire kissofire mentioned this pull request May 10, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request May 10, 2022
Open
@ron-a20 ron-a20 mentioned this pull request May 10, 2022
Open
@molllyn1 molllyn1 mentioned this pull request May 11, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 25, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 26, 2022
Open
@137717unity 137717unity mentioned this pull request Sep 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Sep 27, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Sep 29, 2022
Open
This was referenced Sep 29, 2022
Open
Open
This was referenced Oct 5, 2022
Open
Open
@snyk-bot snyk-bot mentioned this pull request Oct 6, 2022
Open
@137717unity 137717unity mentioned this pull request Oct 7, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 7, 2022
Open
This was referenced Oct 8, 2022
Open
Open
@137717unity 137717unity mentioned this pull request Oct 9, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 9, 2022
Open
@kissofire kissofire mentioned this pull request Oct 25, 2022
Open
@molllyn1 molllyn1 mentioned this pull request Oct 26, 2022
Open
@baby636 baby636 mentioned this pull request Oct 26, 2022
Open
@snyk-bot snyk-bot mentioned this pull request Oct 26, 2022
Open
@wedataintelligence wedataintelligence mentioned this pull request Oct 26, 2022
Open
This was referenced Oct 26, 2022
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@himself65 himself65 himself65 approved these changes

@DerekNonGeneric DerekNonGeneric DerekNonGeneric approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

doc: active module page not highlighted in sidebar nav
4 participants
@aduh95 @DerekNonGeneric @nodejs-github-bot @himself65