test: skip internet for test-npm-install #36933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
darcyclarke
approved these changes
Jan 14, 2021
richardlau
approved these changes
Jan 14, 2021
Trott
approved these changes
Jan 15, 2021
Lxxyx
approved these changes
Jan 15, 2021
jasnell
approved these changes
Jan 15, 2021
MylesBorins
added
the
fast-track
|
Can we fast-track? |
MylesBorins
added
the
author ready
lpinca
approved these changes
Jan 16, 2021
richardlau
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Disabling any internet-required features (namely audit and update-notifer) in order for the test to work without an internet connection. - Fixes: nodejs#36895 PR-URL: nodejs#36933 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
aduh95
force-pushed
the
test-npm-install-skip-internet-required-features
branch
from
5c3e70c
to
887f199
Compare
|
Landed in 887f199 |
ruyadorno
added a commit
that referenced
this pull request
Jan 22, 2021
Disabling any internet-required features (namely audit and update-notifer) in order for the test to work without an internet connection. - Fixes: #36895 PR-URL: #36933 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 1, 2021
Disabling any internet-required features (namely audit and update-notifer) in order for the test to work without an internet connection. - Fixes: #36895 PR-URL: #36933 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
This was referenced Nov 8, 2022
This was referenced Jun 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Disabling any internet-required features (namely audit and
update-notifer) in order for the test to work without an internet
connection.