Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: runtime deprecate access to process.binding('async_wrap') #37576

Closed
wants to merge 2 commits into from
Closed

lib: runtime deprecate access to process.binding('async_wrap') #37576

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
148c463
lib: runtime deprecate access to process.binding('async_wrap')
jasnell Mar 3, 2021
dfcd37b
fixup! lib: runtime deprecate access to process.binding('async_wrap')
jasnell Mar 3, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 11 additions & 0 deletions lib/internal/bootstrap/loaders.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,6 +105,10 @@ const internalBindingAllowlist = new SafeSet([
'zlib',
]);

const runtimeDeprecatedList = new SafeSet([
'async_wrap',
]);

// Set up process.binding() and process._linkedBinding().
{
const bindingObj = ObjectCreate(null);
Expand All @@ -114,6 +118,13 @@ const internalBindingAllowlist = new SafeSet([
// Deprecated specific process.binding() modules, but not all, allow
// selective fallback to internalBinding for the deprecated ones.
if (internalBindingAllowlist.has(module)) {
if (runtimeDeprecatedList.has(module)) {
runtimeDeprecatedList.delete(module);
process.emitWarning(
`Access to process.binding('${module}') is deprecated.`,
'DeprecationWarning',
'DEP0111');
}
return internalBinding(module);
}
// eslint-disable-next-line no-restricted-syntax
Expand Down