Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x backport] errors: print original exception context #37700

Conversation

bcoe
Copy link
Contributor

@bcoe bcoe commented Mar 10, 2021

When --enable-source-maps is set, the error context displayed
above the stack trace now shows original source rather than
transpiled.

PR-URL: #33491
Reviewed-By: Anna Henningsen anna@addaleax.net
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: Ben Noordhuis info@bnoordhuis.nl

@bcoe bcoe requested a review from ruyadorno March 10, 2021 21:01
@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. v14.x labels Mar 10, 2021
src/env-inl.h Outdated Show resolved Hide resolved
src/env.h Outdated Show resolved Hide resolved
@nodejs-github-bot
Copy link
Collaborator

When --enable-source-maps is set, the error context displayed
above the stack trace now shows original source rather than
transpiled.

Backport-PR-URL: nodejs#37700
PR-URL: nodejs#33491
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@bcoe bcoe force-pushed the backport-print-original-exception-context branch from 3049d94 to efe28e3 Compare March 10, 2021 23:36
@bcoe bcoe requested a review from BridgeAR March 10, 2021 23:38
@bcoe
Copy link
Contributor Author

bcoe commented Mar 10, 2021

@BridgeAR we'd like to get improved stack traces for source maps into Node 14, but it's a bit of a traffic jam:

#33491
#35903
#35915
#37252
#37362

Would you be a good person to loop into these backport PRs along with @ruyadorno?

ruyadorno pushed a commit that referenced this pull request Mar 11, 2021
When --enable-source-maps is set, the error context displayed
above the stack trace now shows original source rather than
transpiled.

Backport-PR-URL: #37700
PR-URL: #33491
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
@ruyadorno
Copy link
Member

Landed in 6562506

@ruyadorno ruyadorno closed this Mar 11, 2021
MylesBorins pushed a commit that referenced this pull request Apr 6, 2021
When --enable-source-maps is set, the error context displayed
above the stack trace now shows original source rather than
transpiled.

Backport-PR-URL: #37700
PR-URL: #33491
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants